p5odds.odd bug fix #2629
Merged
p5odds.odd bug fix #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constraint was looking for _all_ descendant text nodes of eg element, not just child text nodes. That means that if there is any phrase-level encoding in an eg element there is more than one text node that has (for example) position()=last(), and the XPath fails because only one item is allowed as the first argument to matches().
Per suggestion of @martindholmes, instead of trying to select the correct descendant text node(s), just examine the string value of the entire eg element as a whole. The string() function call is not technically necessary (because matches() wants a string there, it would happen automagically), but its use makes what we are doing explicit and obvious.
|
Correction to OP: @martindholmes suggests that we, instead of attempting to get the right text() node to test, just test the entire string value of the |
sydb
added a commit
that referenced
this pull request
Dec 4, 2024
The bug addressed by #2629 prevents this from building. Committing now so I can apply that bug-fix here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constraint on
<eg>was looking for all descendant text nodes, not just child text nodes. That means that if there is any phrase-level encoding in an<eg>then there is more than one text node that has (for example)position()=last(), and the XPath fails because only one item is allowed as the first argument tomatches().Fix seems trivial: search only for child text nodes, not descendant text nodes.
Note: I am not sure the “TEI: ODD” label is correctly — it might be for the TEI language defined by the Guidelines, not the TEI language defined for the Guidelines. Sigh. Anyway, this is high priority because it is holding up work on #2516.