p5odds: Allow "URN" as value of @type of <idno>
#2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I am not sure the “TEI: ODD” label is correctly applied to this — it might be for the TEI language defined by the Guidelines, not the TEI language defined for the Guidelines. Sigh. Anyway, this is high priority because it is holding up work on #2516. |
sydb
requested review from
hcayless,
jamescummings,
tuurma,
torstenroeder,
martindholmes,
ebeshero,
sabineseifert,
HelenaSabel,
trishaoconnor,
martinascholger,
joeytakeda and
GusRiva
joeytakeda
reviewed
Dec 4, 2024
martindholmes
approved these changes
Dec 4, 2024
sydb
added a commit
that referenced
this pull request
Dec 4, 2024
of handNotes, courtesy of Christian Thomas. This commit will not build as is, it needs the change to p5odds of #2630 before it will build properly.
sydb
removed request for
hcayless,
jamescummings,
tuurma,
torstenroeder and
ebeshero
sydb
removed request for
sabineseifert,
HelenaSabel,
trishaoconnor,
martinascholger and
GusRiva
|
I've tested and built guidelines and exemplars with it. All good, and the update is definitely useful in the cause of new and wider-ranging examples of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Slack conversation with @raffazizzi , add "URN" as possible value to
@typeof<idno>in p5odds. While I was there I also:I have checked. Use of
<idno type="URN">results in output that is not really pretty in the HTML Guidelines (specifically, in the Bibliography), but not particularly ugly, either, and does not falsely imply that your web browser will open a URN. (Which use of<ptr target="urn:duck:billed:platypus"/>would.)I have also checked, and there were no occurrences of
<idno type="url">in P5, so changing this to "URL" should not cause problems.