Skip to content

Commit

Permalink
Ensure detach is done using right element
Browse files Browse the repository at this point in the history
  • Loading branch information
Tyriar committed Oct 13, 2023
1 parent 0608ebd commit 0301ad1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/terminal/browser/terminalEditor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ export class TerminalEditor extends EditorPane {

override clearInput(): void {
super.clearInput();
if (this._overflowGuardElement && this._editorInput?.terminalInstance?.domElement === this._overflowGuardElement) {
this._editorInput?.detachInstance();
if (this._overflowGuardElement && this._editorInput?.terminalInstance?.domElement.parentElement === this._overflowGuardElement) {
this._editorInput.terminalInstance?.detachFromElement();
}
this._editorInput = undefined;
}
Expand Down

0 comments on commit 0301ad1

Please sign in to comment.