[fix] Add ENABLE_PRINTF switch to control logging information
#12
Conversation
Jules-Kong
requested review from
Jules-Kong,
yangzexia and
yangkex
and removed request for
Jules-Kong
spike_main/spike.cc
Outdated
| "to the %ld KiB page size: [0x%llX, 0x%llX]\n", | ||
| base0, base0 + size0 - 1, long(PGSIZE / 1024), base, base + size - 1); | ||
| base0, base0 + size0 - 1, long(PGSIZE / 1024), base, base + size - 1);) |
config.h.in
Outdated
|
|
||
| #ifdef ENABLE_PRINTF | ||
| #undef DEBUG | ||
| #define DEBUG(x) x; |
configure
Outdated
| # Check enviroment virable ENABLE_PRINTF | ||
| if [ "$ENABLE_PRINTF" = "ON" ]; then | ||
| CXXFLAGS+=" -DENABLE_PRINTF=ON " | ||
| fi |
There was a problem hiding this comment.
configure file is an auto-generated file, upstream files should be updated as well.
There was a problem hiding this comment.
configure file is an auto-generated file, upstream files should be updated as well.
It is not an auto-generated file, run this script to generate makefile
There was a problem hiding this comment.
It is not an auto-generated file, run this script to generate makefile
configure is auto-generated from configure.ac, you can ref to GNU autoconf manual for detail.
There was a problem hiding this comment.
It is not an auto-generated file, run this script to generate makefile
configure is auto-generated from configure.ac, you can ref to GNU autoconf manual for detail.
I compared the autoconf genarated file with configure, the authour made many changes in configure file, so I think it's ok to do some change in configure file not in configure.ac
spike_main/spike_device.cc
Outdated
| @@ -298,7 +298,7 @@ int spike_device::run(meta_data* knl_data,uint64_t knl_start_pc){ | |||
| uint64_t knlbase=knl_data->metaDataBaseAddr; | |||
|
|
|||
| if ((ldssize)>0x10000000) { | |||
| fprintf(stderr, "lds size is too large. please modify VBASEADDR"); | |||
| DEBUG(fprintf(stderr, "lds size is too large. please modify VBASEADDR");) | |||
There was a problem hiding this comment.
Indent
The program's coding style maybe later needed to be modified,I think the maintainer is supposed to create a PR to do this, I will later modify what I do in this PR
|
please merge two commits into one. |
#11