Skip to content

Commit

Permalink
Include shellcheck pre-commit in main pre-commit
Browse files Browse the repository at this point in the history
Disabled by default, run with `pre-commit run --all --hook-stage manual`
  • Loading branch information
manics committed Jul 23, 2023
1 parent 800307a commit 52d5e0c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test-chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ jobs:
- name: Install dependencies
run: pip install pre-commit

- name: Run shellcheck linter
run: pre-commit run --all --config .pre-commit-config-shellcheck.yaml
- name: Run all stages including shellcheck (disabled by default)
run: pre-commit run --all --hook-stage manual

lint_and_validate_rendered_templates:
runs-on: ubuntu-22.04
Expand Down
6 changes: 0 additions & 6 deletions .pre-commit-config-shellcheck.yaml

This file was deleted.

8 changes: 8 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,14 @@ repos:
hooks:
- id: flake8

- repo: https://github.com/gruntwork-io/pre-commit
rev: v0.1.22
hooks:
# This requires shellcheck to be installed manually so is disabled by default
- id: shellcheck
stages:
- manual

# pre-commit.ci config reference: https://pre-commit.ci/#configuration
ci:
autoupdate_schedule: monthly

0 comments on commit 52d5e0c

Please sign in to comment.