Refactored BackButton to navigate properly, refactored navbar #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataHub bar now global across site with search rendering conditionally. Backbutton navigation solved with simpler nvigation logic. Resolves #280
OnComponentWillUnmount still clear selectedCollection from store in Historical Imagery Component. Removed this lifecycle to keep selectedCollection so that backButton can use this prop to navigate back from cart.
Roll back to change only back button and cart link
| @@ -624,7 +634,7 @@ class OrderTnrisDataForm extends Component { | |||
| This dataset is already in the shopping cart. | |||
| </p> | |||
| <p className="mdc-typography--body2"> | |||
| Please visit the shopping cart to finalize your order. | |||
| Please visit the <button style={{color: '#1E8DC1'}} className="mdc-button" onClick={this.handleOrderCartView}>shopping cart</button> to finalize your order. | |||
There was a problem hiding this comment.
I am seeing this warning in the console when I click the text to navigate to the cart: submission canceled because the form is not connected
I think the browser is defaulting the button to type="submit" since its type hasn't been declared implicitly and it is in a form.
https://www.w3schools.com/tags/att_button_type.asp
add the attributetype="button" to the button element to prevent this warning on click
Link button to cart after ordering collection resulted in an error on click. Issue resolved by adding type='button' to button attributes.
JasonKleinert
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataHub bar now global across site with search rendering conditionally. Backbutton navigation solved with simpler nvigation logic. Resolves #280