[cmake] When using mkl enforce single dynamic lib and explicitly set mkl_interface_layer #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mkl_interface_layer
Wentzell
force-pushed
the
DEV_MKL_INTERFACE_LAYER
branch
from
a041e75
to
06f3946
Compare
the-hampel
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Looks good to me and works as expected. Now, without setting MKL_INTERFACE_LAYER there are no more segmentation faults. Very nice.
I have one small comment regarding the mkl.h include, that gives my machine some trouble. See my review. Maybe, once can also grep the LAPACK ROOT dir after cmake found MKL? But I could not find any variable that stores the root dir. However, MKLROOT should always be set when MKL is installed.
the-hampel
approved these changes
Sep 18, 2023
|
Thank you @the-hampel for the feedback! |
Wentzell
added a commit
that referenced
this pull request
Sep 18, 2023
…mkl_interface_layer (#48) * When using mkl enforce single dynamic lib and explicitly set mkl_interface_layer * When detecting MKL as BLAS/Lapack distrubtion, make sure headers are found through MKLROOT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.