feat: Reimplement drag drop files on sql migration #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Enhancement
seakrueger
force-pushed
the
reimplement-drag-drop
branch
3 times, most recently
from
18d57c5
to
0ddd9c7
Compare
seakrueger
force-pushed
the
reimplement-drag-drop
branch
5 times, most recently
from
df66b2e
to
34376ec
Compare
|
Sorry for the delay, this guy kind of slipped away into several tightly related features. Old Dialog: |
seakrueger
force-pushed
the
reimplement-drag-drop
branch
from
6773328
to
d55186f
Compare
* Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <[email protected]> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <[email protected]> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <[email protected]> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <[email protected]> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <[email protected]> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids * Add newly dragged-in files to SQL database * Fix buttons being inconsistant across platforms * Fix ruff formatting * Rename "override" button to "overwrite" --------- Co-authored-by: yed podtrzitko <[email protected]> Co-authored-by: Travis Abendshien <[email protected]> Co-authored-by: Sean Krueger <[email protected]>
seakrueger
force-pushed
the
reimplement-drag-drop
branch
from
d55186f
to
5d36abc
Compare
| item.setEditable(False) | ||
| self.model.appendRow(item) | ||
|
|
||
| self.show() |
There was a problem hiding this comment.
When an action is required, I'd expect the window will gain focus. So I'd add self.driver.main_window.raise_() here. Otherwise the result might look like this, so I might not be even aware the drag&drop action havent finished:
There was a problem hiding this comment.
Added, but window already raised on my system so unsure if that is fixed for you
* Handle Qt events for main window in ts_qt.py * Replace magic values with enums * Match import duplicate file dialog to delete missing entry dialog * Remove excessive progess widgets * Add docstrings and logging
Extracts the create_progress_bar function from drop_import to the ProgressWidget class. Instead of creating a ProgressWidget, FunctionIterator, and CustomRunnable every time a thread-safe progress widget is needed, the from_iterable function in ProgressWidget now handles all of that.
seakrueger
force-pushed
the
reimplement-drag-drop
branch
from
5d36abc
to
803f430
Compare
|
Updated with feedback, still no tests as getting a lot of weird errors trying to work with files and copying in pytest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 4e4bf6b
commit 2f9ae0d
commit 803f430
Commits and commits title/messages are formatted to maintain authorship and split features, don't squash on merge