fix(QAPPINT-803): Fixing timestamp attribute for iteratorType=AT_TIME… #125
+94
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2par0
reviewed
Dec 2, 2024
| @@ -52,6 +52,9 @@ public class Kinesis2Configuration implements Cloneable { | |||
| @UriParam(label = "consumer", | |||
| description = "The sequence number to start polling from. Required if iteratorType is set to AFTER_SEQUENCE_NUMBER or AT_SEQUENCE_NUMBER") | |||
| private String sequenceNumber = ""; | |||
| @UriParam(label = "consumer", | |||
| description = "The message timestamp to start polling from. Required if iteratorType is set to AFTER_SEQUENCE_NUMBER or AT_SEQUENCE_NUMBER") | |||
There was a problem hiding this comment.
required if iteratorType is AT_TIMESTAMP ?
is it really required ?
There was a problem hiding this comment.
For AT_TIMESTAMP only. I'll fix this description, thank you
ArtemMarchukQlikCom
force-pushed
the
bugfix/tesb/camel-3.20.6.x/QAPPINT-803
branch
from
3e3ad4e to
13247f6
Compare
…STAMP for Kinesis2Component
ArtemMarchukQlikCom
force-pushed
the
bugfix/tesb/camel-3.20.6.x/QAPPINT-803
branch
from
13247f6 to
8b7a972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…STAMP for Kinesis2Component
Description
Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.