feat(QTDI-113): Support Java 17 compilation #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor compiler properties - bump maven-surefire-plugin - bump maven-shade-plugin - bump maven-resource-plugin - bump maven-javadoc-plugin - bump maven-assembly-plugin - bump maven-antrun-plugin - bump maven to 3.9.9 - bump maven-invoker-plugin - bump maven-site-plugin - bump maven-source-plugin maven-release-plugin - bump maven-jar-plugin to 3.4.2 - bump maven-deploy-plugin to 3.1.3 - refactor maven-deploy-plugin.version - bump maven-deploy-plugin to 3.1.3 - bump maven-dependency-plugin to 3.8.0 - bump maven-clean-plugin to 3.4.0 - bump maven-compiler-plugin to 3.13.0 - set source/target to 17
- remove mockito from project
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # bom/pom.xml
This comment has been minimized.
This comment has been minimized.
# Conflicts: # documentation/src/main/antora/modules/ROOT/pages/_partials/generated_contributors.adoc # pom.xml
This comment has been minimized.
This comment has been minimized.
# Conflicts: # .tool-versions
undx
changed the title
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: org.talend.sdk.component:component-runtime |
| @@ -150,6 +150,9 @@ | |||
| <properties> | |||
| <scm.repository>talend/component-runtime</scm.repository> | |||
|
|
|||
| <maven.compiler.source>17</maven.compiler.source> | |||
There was a problem hiding this comment.
When do we plan to use this new component-runtime in Studio?
We can't use it before R2025-02, we should support Java 8 and Java11 before R2025-02
There was a problem hiding this comment.
Yeah, aware on the delays. We may postpone to next rel.
| @@ -59,7 +60,7 @@ | |||
| <dependency> | |||
| <groupId>org.apache.maven.plugin-tools</groupId> | |||
| <artifactId>maven-plugin-annotations</artifactId> | |||
| <version>${mvn-minimal.version}</version> | |||
| <version>${maven-plugin-annotations.version}</version> | |||
There was a problem hiding this comment.
Where do we use "mvn-minimal.version"?
There was a problem hiding this comment.
It's used in requireMavenVersion for enforcer plugin.
ozhelezniak-talend
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://qlik-dev.atlassian.net/browse/QTDI-113