Skip to content

Commit

Permalink
fix(TDOPS-5794): hideExternal on Link (#5103)
Browse files Browse the repository at this point in the history
* TDOPS-5794: Pass hideExternal to Linkable

* TDOPS-5794: changeset
  • Loading branch information
lmaillet authored Jan 5, 2024
1 parent d4434db commit 78928ee
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/spotty-coats-admire.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/design-system': patch
---

Pass hideExternal to Linkable component
7 changes: 4 additions & 3 deletions packages/design-system/src/components/Link/Link.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import { forwardRef, ReactElement, Ref, useCallback, useMemo } from 'react';
import { useTranslation } from 'react-i18next';

import classNames from 'classnames';
import { useTranslation } from 'react-i18next';

import { DeprecatedIconNames } from '../../types';
import { I18N_DOMAIN_DESIGN_SYSTEM } from '../constants';
import { Linkable, LinkableType, isBlank as targetCheck } from '../Linkable';

import style from './Link.module.scss';
import { I18N_DOMAIN_DESIGN_SYSTEM } from '../constants';

export type LinkComponentProps = {
/** The icon to display before */
Expand All @@ -19,7 +20,7 @@ export type LinkProps = Omit<LinkableType, 'className'> & LinkComponentProps;

const Link = forwardRef(
(
{ children, disabled, href, target, title, hideExternalIcon, ...rest }: LinkProps,
{ children, disabled, href, target, title, ...rest }: LinkProps,
ref: Ref<HTMLAnchorElement>,
) => {
const { t } = useTranslation(I18N_DOMAIN_DESIGN_SYSTEM);
Expand Down

0 comments on commit 78928ee

Please sign in to comment.