Skip to content

Commit

Permalink
revert fix of find.js for investigation
Browse files Browse the repository at this point in the history
  • Loading branch information
smouillour committed Oct 17, 2023
1 parent f305cfb commit bd452e0
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 14 deletions.
23 changes: 12 additions & 11 deletions .github/actions/setup-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ runs:
- uses: pnpm/action-setup@v2
with:
version: 8

- name: Set up Node.js
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d #v3.8.1
with:
Expand All @@ -18,15 +19,15 @@ runs:
scope: '@talend'
cache: 'pnpm'

# - name: Get pnpm cache directory path
# id: pnpm-cache-dir-path
# shell: bash
# run: echo "dir=$(pnpm store path)" >> $GITHUB_OUTPUT
- name: Get pnpm cache directory path
id: pnpm-cache-dir-path
shell: bash
run: echo "dir=$(pnpm store path)" >> $GITHUB_OUTPUT

# - uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 #v3.3.2
# id: pnpm-cache # use this to check for `cache-hit` (`steps.pnpm-cache.outputs.cache-hit != 'true'`)
# with:
# path: ${{ steps.pnpm-cache-dir-path.outputs.dir }}
# key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
# restore-keys: |
# ${{ runner.os }}-pnpm-
- uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 #v3.3.2
id: pnpm-cache # use this to check for `cache-hit` (`steps.pnpm-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.pnpm-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-
3 changes: 2 additions & 1 deletion fork/dynamic-cdn-webpack-plugin/src/find.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ function findPackages(scope, name, buff = []) {
const result = buff.concat(
...roots.map(root => findPackagesFromNonScopeFolder(scope, name, root)),
);
return [...new Set(result)];
// return [...new Set(result)];
return result;
}

module.exports = {
Expand Down
2 changes: 1 addition & 1 deletion fork/dynamic-cdn-webpack-plugin/src/find.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('findPackages', () => {
require('fs').__setMockFiles(MOCK_FILE_INFO);
});

test.only('should find root and nested package', () => {
test('should find root and nested package', () => {
// when
const result = findPackages(undefined, 'react');

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"webpack": "^5.73.0"
},
"scripts": {
"postinstall": "pnpm --sort -r run build:lib",
"postinstall": "pnpm --sort -r --stream run build:lib",
"pre-release": "pnpm -r run pre-release",
"start": "pnpm --filter @talend/ui-playground run start",
"start-storybook": "pnpm --filter @talend/ui-storybook-one run start",
Expand Down

0 comments on commit bd452e0

Please sign in to comment.