fix(): Fix security issue on regular expression (#5019)

Talend · Nov 29, 2023 · c508840 · c508840
1 parent 795a12e
commit c508840
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/nice-schools-cry.md b/.changeset/nice-schools-cry.md
@@ -0,0 +1,5 @@
+---
+'@talend/react-cmf': minor
+---
+
+fix(): Fix security issue on regular expression
diff --git a/packages/cmf/__tests__/settings.test.js b/packages/cmf/__tests__/settings.test.js
@@ -111,6 +111,7 @@ describe('settings', () => {
 	describe('withoutHOC', () => {
 		it('should remove all HOC prefix', () => {
 			expect(withoutHOC('Connect(CMF(Container(MyComponent)))')).toBe('MyComponent');
+			expect(withoutHOC('Connect(CMF(Container(Comp_+*[]~-=@{})))')).toBe('Comp_+*[]~-=@{}');
 		});
 	});
 });
diff --git a/packages/cmf/src/settings.js b/packages/cmf/src/settings.js
@@ -27,11 +27,12 @@ export function generateDefaultViewId(viewId, componentName, componentId) {
 
 /**
  * Extract component name without HOC
- * @param {String} viewId Connect(CMF(Container(MyComponent)))
+ * @param {String} componentName Connect(CMF(Container(MyComponent)))
  * @return {String} MyComponent
  */
 export function withoutHOC(componentName) {
-	return componentName.match(/.*\((.*?)\)/)[1];
+	const parts = componentName.split('(');
+	return parts[parts.length - 1].replaceAll(')', '');
 }
 
 /**