chore(ARCH-482): bump react 18 #4739

jmfrancois · 2023-05-30T08:23:44Z

What is the problem this PR is trying to solve?

we are on react 17.
we have re-written all our test using react testing-library.

What is the chosen solution to this problem?

upgrade react and @types/react to 18.
some tests fails with no real reasons but it should be reworked by upgrading testing-library as we have lots console.errors messages from it. We have just use xit from it.

Also remember react-bootstrap is deprecated so tests are also xit on error like ref as string is not supported anymore.
If you have an issue with a react-bootstrap component you should just use the DS equivalent.

http://4739.talend.surge.sh/

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

…to jmfrancois/chore/bump-react

…ub.com>

github-actions · 2023-10-23T08:28:13Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.19% (1271/1425)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.38% (5601/6197)	81.64% (3215/3938)	87.73% (1416/1614)
containers	83.53% (1385/1658)	74.67% (687/920)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
design-system	63.71% (836/1312)	45.86% (394/859)	50.28% (179/356)
faceted-search	85.03% (693/815)	76.63% (269/351)	81.75% (242/296)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.74% (1678/1957)	75.37% (903/1198)	84.43% (472/559)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (66/66)	90.9% (10/11)	100% (16/16)

github-actions · 2023-10-23T09:27:32Z

Size Change: -985 B (0%)

Total Size: 13.4 MB

Filename	Size	Change
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB	+974 B (+1%)
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13 kB	-974 B (-7%)	✅
`./packages/cmf/dist/TalendReactCmf.js`	638 kB	+1.82 kB (0%)
`./packages/cmf/dist/TalendReactCmf.min.js`	121 kB	-781 B (-1%)
`./packages/components/dist/TalendReactComponents.js`	2.98 MB	+974 B (0%)
`./packages/components/dist/TalendReactComponents.min.js`	661 kB	-1 kB (0%)
`./packages/containers/dist/TalendReactContainers.js`	541 kB	+974 B (0%)
`./packages/containers/dist/TalendReactContainers.min.js`	105 kB	-987 B (-1%)
`./packages/dataviz/dist/TalendReactDataviz.js`	372 kB	+974 B (0%)
`./packages/dataviz/dist/TalendReactDataviz.min.js`	63.6 kB	-1 kB (-2%)
`./packages/design-system/dist/TalendDesignSystem.js`	1.18 MB	+665 B (0%)
`./packages/design-system/dist/TalendDesignSystem.min.js`	235 kB	-1.08 kB (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	454 kB	+974 B (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	103 kB	-1 kB (-1%)
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	51.5 kB	-1.24 kB (-2%)
`./packages/forms/dist/TalendReactForms.js`	781 kB	+974 B (0%)
`./packages/forms/dist/TalendReactForms.min.js`	205 kB	-989 B (0%)
`./packages/icons/dist/TalendIcons.js`	752 kB	+771 B (0%)
`./packages/icons/dist/TalendIcons.min.js`	606 kB	-974 B (0%)
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB	+974 B (+1%)
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB	-987 B (-4%)
`./packages/stepper/dist/TalendReactStepper.js`	97.4 kB	+974 B (+1%)
`./packages/stepper/dist/TalendReactStepper.min.js`	9.64 kB	-1 kB (-9%)	✅

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	105 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.9 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.css`	403 kB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB
`./packages/components/dist/TalendReactComponents.min.css`	210 kB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.74 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB
`./packages/design-system/dist/TalendDesignSystem.css`	281 kB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.44 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	172 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.48 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.8 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.51 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	17.1 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	39.3 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.37 kB
`./packages/forms/dist/TalendReactForms.min.css`	13.4 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.41 kB
`./packages/http/dist/TalendHttp.js`	24.9 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.33 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.1 kB
`./packages/icons/dist/react.esm.js`	585 kB
`./packages/icons/dist/react.js`	623 kB
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.4 kB
`./packages/jsfc/dist/index.js`	86.8 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB
`./packages/theme/dist/bootstrap.css`	172 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

chore: bump react 18

913bbc3

jmfrancois temporarily deployed to pull_request_unsafe May 30, 2023 08:23 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe May 30, 2023 08:23 — with GitHub Actions Failure

jmfrancois added 2 commits May 31, 2023 13:50

chore: try to fix DS

867bede

Merge branch 'master' into jmfrancois/chore/bump-react

aacc8a1

jmfrancois temporarily deployed to pull_request_unsafe June 5, 2023 13:40 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe June 5, 2023 13:40 — with GitHub Actions Failure

Merge branch 'jmfrancois/chore/bump-react' of github.com:Talend/ui in…

52f6519

…to jmfrancois/chore/bump-react

jmfrancois temporarily deployed to pull_request_unsafe June 5, 2023 15:42 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe June 5, 2023 15:42 — with GitHub Actions Failure

chore: adjust types

1c4ae9b

jmfrancois temporarily deployed to pull_request_unsafe June 5, 2023 18:56 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe June 5, 2023 18:56 — with GitHub Actions Failure

Co-authored-by: Sebastien LE MOUILLOUR <[email protected]…

3d701e6

…ub.com>

jmfrancois temporarily deployed to pull_request_unsafe June 7, 2023 14:58 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe June 7, 2023 14:58 — with GitHub Actions Failure

jmfrancois temporarily deployed to pull_request_unsafe October 23, 2023 08:07 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 23, 2023 08:08 — with GitHub Actions Failure

jmfrancois temporarily deployed to pull_request_unsafe October 23, 2023 08:08 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 23, 2023 08:08 — with GitHub Actions Failure

chore: upgrade react-is

feeddb0

jmfrancois temporarily deployed to pull_request_unsafe October 23, 2023 08:28 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 23, 2023 08:28 — with GitHub Actions Error

jmfrancois temporarily deployed to pull_request_unsafe October 23, 2023 08:28 — with GitHub Actions Inactive

fix: element is not id

e80cbf3

jmfrancois temporarily deployed to pull_request_unsafe October 23, 2023 09:00 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe October 23, 2023 09:00 — with GitHub Actions Error

chore: cleanup

4dff13e

jmfrancois temporarily deployed to pull_request_unsafe October 23, 2023 09:01 — with GitHub Actions Inactive

jmfrancois temporarily deployed to pull_request_unsafe October 23, 2023 09:02 — with GitHub Actions Inactive

jmfrancois marked this pull request as ready for review October 23, 2023 09:15

romainseb approved these changes Oct 23, 2023

View reviewed changes

lmaillet approved these changes Oct 23, 2023

View reviewed changes

jmfrancois merged commit 96d6884 into master Oct 23, 2023
10 checks passed

jmfrancois deleted the jmfrancois/chore/bump-react branch October 23, 2023 09:42

jmfrancois had a problem deploying to pull_request_unsafe October 23, 2023 09:42 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ARCH-482): bump react 18 #4739

chore(ARCH-482): bump react 18 #4739

jmfrancois commented May 30, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023

chore(ARCH-482): bump react 18 #4739

chore(ARCH-482): bump react 18 #4739

Conversation

jmfrancois commented May 30, 2023 • edited Loading

github-actions bot commented Oct 23, 2023 • edited Loading

github-actions bot commented Oct 23, 2023

jmfrancois commented May 30, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023 •

edited

Loading