feat(TDP-12106): rework http interceptors to access request object and return promise #4899

Nigui · 2023-09-20T09:45:19Z

What is the problem this PR is trying to solve?

Current interceptors do not have access to request, which is useful in some situation (e.g to intercept only get methods).
Current interceptors can't identify precisely specific calls (e.g some function send an http request but based on business logic we want to ignore 404 responses on this request to not warn user).
Current interceptors return void so they can't modify the response based on some business logic, or trigger another http call before resolve.

What is the chosen solution to this problem?

You can have more information in the readme.

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-09-20T10:08:24Z

4899

Demo is available here

github-actions · 2023-09-20T10:12:43Z

Size Change: +553 B (0%)

Total Size: 13.2 MB

Filename	Size	Change
`./packages/http/dist/TalendHttp.js`	24.9 kB	+413 B (+2%)
`./packages/http/dist/TalendHttp.min.js`	5.33 kB	+140 B (+3%)

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	105 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.9 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	163 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13.9 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js`	637 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js`	122 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.css`	403 kB
`./packages/components/dist/TalendReactComponents.js`	2.94 MB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.47 kB
`./packages/components/dist/TalendReactComponents.min.css`	210 kB
`./packages/components/dist/TalendReactComponents.min.js`	630 kB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.55 kB
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB
`./packages/containers/dist/TalendReactContainers.js`	540 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.74 kB
`./packages/containers/dist/TalendReactContainers.min.js`	106 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB
`./packages/dataviz/dist/TalendReactDataviz.js`	371 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	64.6 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB
`./packages/design-system/dist/TalendDesignSystem.css`	281 kB
`./packages/design-system/dist/TalendDesignSystem.js`	1.07 MB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.3 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	172 kB
`./packages/design-system/dist/TalendDesignSystem.min.js`	211 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.33 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.8 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	453 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.51 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	17.1 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	104 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	52.7 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	39.3 kB
`./packages/forms/dist/TalendReactForms.js`	780 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.5 kB
`./packages/forms/dist/TalendReactForms.min.css`	13.4 kB
`./packages/forms/dist/TalendReactForms.min.js`	206 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.54 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.1 kB
`./packages/icons/dist/react.esm.js`	585 kB
`./packages/icons/dist/react.js`	623 kB
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	752 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	607 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.4 kB
`./packages/jsfc/dist/index.js`	86.8 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	133 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	22 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB
`./packages/stepper/dist/TalendReactStepper.js`	96.4 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB
`./packages/stepper/dist/TalendReactStepper.min.js`	10.6 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB
`./packages/theme/dist/bootstrap.css`	172 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

github-actions · 2023-09-21T06:57:46Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.17% (1268/1422)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	89.95% (5609/6235)	81.02% (3212/3964)	86.88% (1418/1632)
containers	83.53% (1385/1658)	74.67% (687/920)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
faceted-search	85.03% (693/815)	76.63% (269/351)	81.75% (242/296)
flow-designer	69.95% (652/932)	66.66% (356/534)	70.67% (200/283)
forms	86.91% (1701/1957)	76.46% (916/1198)	85.86% (480/559)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (66/66)	90.9% (10/11)	100% (16/16)

…d return promise

Nigui temporarily deployed to pull_request_unsafe September 20, 2023 09:45 — with GitHub Actions Inactive

Nigui temporarily deployed to pull_request_unsafe September 21, 2023 06:37 — with GitHub Actions Inactive

Nigui temporarily deployed to pull_request_unsafe September 21, 2023 12:19 — with GitHub Actions Inactive

Nigui temporarily deployed to pull_request_unsafe September 21, 2023 12:20 — with GitHub Actions Inactive

Nigui marked this pull request as ready for review September 21, 2023 12:20

jmfrancois approved these changes Sep 21, 2023

View reviewed changes

Nigui force-pushed the gnicolas/feat/tdp-12106/http-interceptors branch from 1925af1 to b8009c0 Compare October 9, 2023 09:57

Nigui temporarily deployed to pull_request_unsafe October 9, 2023 09:57 — with GitHub Actions Inactive

Nigui added 6 commits October 9, 2023 15:16

feat(TDP-12106): rework http interceptors to access request object an…

4bea677

…d return promise

add context property in config to access in interceptors

a7c7b23

add doc

47ccf55

add changeset

0d084ec

rework to prevent major changeset

b6a858b

have to clone response to be able to parse body in interceptors

91b3c6c

Nigui force-pushed the gnicolas/feat/tdp-12106/http-interceptors branch from b8009c0 to 91b3c6c Compare October 9, 2023 13:17

Nigui temporarily deployed to pull_request_unsafe October 9, 2023 13:17 — with GitHub Actions Inactive

Nigui enabled auto-merge (squash) October 9, 2023 13:17

romainseb approved these changes Oct 9, 2023

View reviewed changes

Nigui merged commit 72a8f20 into master Oct 9, 2023
10 checks passed

Nigui deleted the gnicolas/feat/tdp-12106/http-interceptors branch October 9, 2023 14:38

Nigui temporarily deployed to pull_request_unsafe October 9, 2023 14:38 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(TDP-12106): rework http interceptors to access request object and return promise #4899

feat(TDP-12106): rework http interceptors to access request object and return promise #4899

Nigui commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Sep 21, 2023 •

edited

Loading

feat(TDP-12106): rework http interceptors to access request object and return promise #4899

feat(TDP-12106): rework http interceptors to access request object and return promise #4899

Conversation

Nigui commented Sep 20, 2023 • edited Loading

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023 • edited Loading

github-actions bot commented Sep 21, 2023 • edited Loading

Nigui commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Sep 21, 2023 •

edited

Loading