Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TFD-16296): Add ellipsis on collapsible panel #4926

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix(TFD-16296): Add ellipsis on collapsible panel #4926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ed644
fix(TFD-16296): Add ellipsis on collapsible panel
mhuchet Oct 6, 2023
c938be5
changeset
mhuchet Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-cups-judge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/react-components': patch
---

fix(TFD-16296): Add ellipsis on collapsible panel header
7 changes: 7 additions & 0 deletions packages/components/src/CollapsiblePanel/CollapsiblePanel.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,13 @@ $tc-collapsible-panel-padding-larger: $padding-larger !default;
display: flex;
align-items: center;
justify-content: space-between;
min-width: 0; // trick to avoid conflict between flex and overflow

> * {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}
}
}
}
Expand Down
12 changes: 12 additions & 0 deletions packages/components/src/CollapsiblePanel/CollapsiblePanel.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,18 @@ export const Header = () => (
<div className="col-lg-offset-1 col-lg-10">
<h1>Collapsible Panel Headers</h1>
<CollapsiblePanel id="panel-header-1" header={[{ label: 'Simple header' }]} />
<CollapsiblePanel
id="panel-header-1"
header={[
{
label:
'Simple header with a very very very very long label that should not completly appear and not push other element outside the headerSimple header with a very very very very long label that should not completly appear and not push other element outside the header',
},
buttonDownload,
]}
>
Panel content
</CollapsiblePanel>
<CollapsiblePanel
id="panel-header-2"
header={[{ label: 'Header with actions' }, { element }]}
Expand Down
Loading