-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT PNPM #4931
Closed
Closed
DRAFT PNPM #4931
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
9e1dac4
big commit pnpm
03d2f1a
syn with master
de2c965
add warn pnpm
160eaf7
fix
5654709
fix: build icons
jmfrancois 3bd4e96
chore: remove enzyme and fix some lint
jmfrancois c72ba53
fix: prettier
jmfrancois 9528a05
chore: lint forms
jmfrancois d104543
chore: CI on pnpm
jmfrancois 2b87eee
chore: CI use pnpm everywhere
jmfrancois d4250ea
chore: remove cache-loader deprecated webpack plugin
jmfrancois 930d566
npmrc + remove @talend/scripts-config-babel
32e236c
chore: add typescript config devDep for VSCode
jmfrancois 7ed6a6a
Merge branch 'smouillour/fix/TDOPS-5327-pnpm' of github.com:Talend/ui…
jmfrancois fd29e1c
revert
c1b527b
add "@talend/scripts-config-typescript": "^11.1.0" in package having …
3313a64
add @talend/scripts-config-babel in each package with babel file
19c72e7
fix import testing-library
bb9e680
a11n add compiler option with type jest
e5d894a
add compiler option in http to add type jest
092b39d
fix package util adding type lodash
8cf2480
try to fix issue with jsfc (missing babel-loader)
fd58ec4
revert change made on jsfc
6749610
remove babel-loader to config-react-webpack and add it (+add webapp) …
7459b77
Merge 67496107ffbb4cabcc41b97ac4e16ee7968c12e9 into cd04f75e88298e9b8…
smouillour 527af9c
chore: pnpm-deduplicate
github-actions[bot] 9001885
remove yarn in tool-versions
4e7be57
change way to call webpack in build-lib-umd
8b6656e
try something to inprove findPackagesFromScopeFolder for PNPM
c2acf07
DRAFT PNPM 2(#4932)
smouillour 9bc0d00
fix lockfile
f305cfb
More fixes (#4934)
smouillour 813cdca
DRAFT PNPM 5 (more fixes) (#4938)
smouillour 89ed2f3
Merge 813cdcacde6cbf5907dbab2275cf31436f0121e1 into 6efd54301e87eff51…
smouillour 46de8a2
chore: pnpm-deduplicate
github-actions[bot] 1c97306
Merge with master and manage conflict
27f728b
fixes after merge
fc54ed1
Sync with master
385f14d
update pnpm lock
74eae57
Merge 385f14dabe1b3b9f2fbc6b05e81747ee2516c33f into 35263dfcb1c1b3028…
smouillour 2e97a30
chore: pnpm-deduplicate
github-actions[bot] 1906997
fix prettier
14add4a
add missing deps in scripts-config-storybook-lib
8c6fd49
Sync with master
4b5cbb3
fix tests impacted by fix with prettier
65d448a
add eslint to module-to-cdn
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@talend/scripts-config-react-webpack': patch | ||
--- | ||
|
||
fix: remove deprecated cache-loader plugin |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@talend/scripts-config-jest': major | ||
--- | ||
|
||
chore: remove enzyme |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,19 +14,19 @@ runs: | |
registry-url: 'https://registry.npmjs.org/' | ||
scope: '@talend' | ||
|
||
- name: Install yarn | ||
- name: Install PNPM | ||
shell: bash | ||
run: npm i -g yarn | ||
run: npm install -g [email protected] | ||
|
||
- name: Get yarn cache directory path | ||
id: yarn-cache-dir-path | ||
- name: Get pnpm cache directory path | ||
id: pnpm-cache-dir-path | ||
shell: bash | ||
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT | ||
run: echo "dir=$(pnpm store path)" >> $GITHUB_OUTPUT | ||
|
||
- uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 #v3.3.2 | ||
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`) | ||
id: pnpm-cache # use this to check for `cache-hit` (`steps.pnpm-cache.outputs.cache-hit != 'true'`) | ||
with: | ||
path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
path: ${{ steps.pnpm-cache-dir-path.outputs.dir }} | ||
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}-yarn- | ||
${{ runner.os }}-pnpm- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# How to run github action locally | ||
|
||
Use the cli ACT: https://github.com/nektos/act | ||
|
||
# How to run PR-TEST | ||
|
||
```bash | ||
act pull_request -j build -W .github/workflows/pr-test.yml | ||
``` | ||
|
||
```bash | ||
act --container-architecture linux/amd64 pull_request -j build -W .github/workflows/pr-test.yml | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
prefer-workspace-packages=true | ||
|
||
#https://pnpm.io/blog/2020/10/17/node-modules-configuration-options-with-pnpm#plugnplay-the-strictest-configuration | ||
hoist=false | ||
|
||
######################################### | ||
# WARNGING Add public-hoist-pattern ONLY if you don't have other solution | ||
######################################### | ||
# ES LINT | ||
public-hoist-pattern[]=eslint-plugin-angular | ||
public-hoist-pattern[]=eslint-plugin-cypress | ||
public-hoist-pattern[]=eslint-plugin-import | ||
public-hoist-pattern[]=eslint-plugin-jest-dom | ||
public-hoist-pattern[]=eslint-plugin-jsx-a11y | ||
public-hoist-pattern[]=eslint-plugin-mdx | ||
public-hoist-pattern[]=eslint-plugin-prettier | ||
public-hoist-pattern[]=eslint-plugin-react | ||
public-hoist-pattern[]=eslint-plugin-react-hooks | ||
public-hoist-pattern[]=eslint-plugin-storybook | ||
public-hoist-pattern[]=eslint-plugin-testing-library | ||
|
||
# STYLE LINT | ||
public-hoist-pattern[]=postcss-scss | ||
public-hoist-pattern[]=stylelint-config-sass-guidelines | ||
|
||
# JEST | ||
public-hoist-pattern[]=jest-environment-jsdom | ||
public-hoist-pattern[]=jest-environment-jsdom-global | ||
public-hoist-pattern[]=jest-serializer-html | ||
|
||
# I18N | ||
public-hoist-pattern[]=i18next | ||
public-hoist-pattern[]=react-i18next | ||
|
||
# OTHERS | ||
public-hoist-pattern[]=autoprefixer | ||
public-hoist-pattern[]=redux* | ||
public-hoist-pattern[]=reakit | ||
|
||
public-hoist-pattern[]=*types* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
nodejs 20.8.1 | ||
# asdf plugin-add pnpm | ||
pnpm 8.9.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related to prettier/prettier-vscode#3007