Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT PNPM 6 #4945

Closed
wants to merge 38 commits into from
Closed

DRAFT PNPM 6 #4945

wants to merge 38 commits into from

Conversation

smouillour
Copy link
Contributor

What is the problem this PR is trying to solve?

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

smouillour and others added 30 commits October 12, 2023 11:25
* remove console.log

* fix ci test

* fix cache ci test

* fix gha + jest config

* fix node_modules path, upgrade babel/core, keep jest only in scripts-core

* chore: pnpm-deduplicate

* add @talend/scripts-config-storybook-lib in every package having storybook

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
smouillour and others added 8 commits October 13, 2023 08:33
* fix babel-loader using resolve

* fix all loaders

* fix test:umd for design-tokens

* fix jest script

* add jest-cli to scripts-core

* add types to assets-api, add babel-core to icons

* fix babel config

* fix babel config using resolve + fix all extends

* try to fix babel for angularjs-annotate

* remove @types/enzyme, add @types/jest to flow-designer + more missign deps

* add missing deps

* fix flow-designer test

* fix test-setup

* add tsconfig.build.json to components and flow-designer

* fix components

* fix package stepper

* fix jest mock

* chore: pnpm-deduplicate

* fix test in dynamic-cdn and scripts-core

* Remove ref to icons in assets-api
remove ref to config-jest in design-token

* chore: pnpm-deduplicate

* fix pnpm version

* fix design-tokens

* stream tests

* add missing jest + reduce usage of cache in GHA

* remove stream and --frozen-lockfile for test

* add console.log

* try to fix test in dynamic-cdn-webpack-plugin

* revert change in dynamic-cdn-plugin

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* revert fix of find.js for investigation

* fix issue with dynamic-cdn-webpack-plugin

* fix gha setup-node

* fix gha setup-node

* set hoist to false and solve dependency issues

* more fixes

* add missing deps in packages or add in npmrc when no other choice

* fix babel-plugin-assets-api tests

* chore: pnpm-deduplicate

* fix dynamic-cdn-webpackp-plugin test

* fix dynamic-cdn-webpack-plugin tests

* fix lint

* fix lint 2

* try something with script-yarn-workspace

* oops

* chore: pnpm-deduplicate

* just for the fun

* temporary fix of find.js

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@smouillour smouillour temporarily deployed to pull_request_unsafe October 20, 2023 10:11 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe October 20, 2023 10:11 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Title Lines Statements Branches Functions
assets-api Coverage: 28%
28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
89.17% (1268/1422) 80.36% (618/769) 88.91% (361/406)
cmf-cqrs Coverage: 87%
87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
90.38% (5601/6197) 81.64% (3215/3938) 87.73% (1416/1614)
containers Coverage: 84%
83.53% (1385/1658) 74.67% (687/920) 75.17% (327/435)
dataviz Coverage: 85%
85.6% (321/375) 66.66% (160/240) 75.64% (118/156)
design-system Coverage: 64%
63.77% (838/1314) 45.88% (396/863) 50.28% (179/356)
faceted-search Coverage: 85%
85.03% (693/815) 76.63% (269/351) 81.75% (242/296)
flow-designer Coverage: 70%
70.06% (653/932) 66.66% (356/534) 71.02% (201/283)
forms Coverage: 86%
86.91% (1701/1957) 76.46% (916/1198) 85.86% (480/559)
http Coverage: 100%
100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
100% (66/66) 90.9% (10/11) 100% (16/16)

@smouillour smouillour closed this Oct 23, 2023
@smouillour smouillour deleted the smouillour/fix/TDOPS-5327-pnpm-6 branch October 23, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants