-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix js exit behaviour #56
base: ansi
Are you sure you want to change the base?
Conversation
b360472
to
1e7ffa4
Compare
@ghivert does this behaviour properly un-break glint in the browser? |
Isn't it dangerous to just do this? Because the process will continue to execute. Are you sure it will stop all other operations? 🙂 (By the way, I did not know GitHub allows to review PR like that, even if you're not on the repo. Weird experience. I just clicked on "leave single comment", so do not take it as me trying to review properly. 😅) |
That's a good point, this won't stop the current process from executing, this is effectively the same as running glint with As a workaround right now, there is the exported but undocumented alternative to @internal
pub fn execute(glint: Glint(a), args: List(String)) -> Result(Out(a), String) i wonder if that is a decent option |
Thinking about this more, with it being an implicit |
Co-authored-by: Guillaume Hivert <[email protected]>
Do you want me to properly test the change? 🙂 |
Thanks for the offer! after thinking about it a bit more, I'm planning some upcoming changes for glint v2 that will rip all IO out of the core so I think it may not be necessary |
This change is a preliminary bugfix in order to addess #55