Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrates shared cache, lib errors #8

Merged
merged 22 commits into from
Jan 30, 2023
Merged

Integrates shared cache, lib errors #8

merged 22 commits into from
Jan 30, 2023

Conversation

VargaElod23
Copy link
Contributor

No description provided.

@VargaElod23 VargaElod23 requested a review from rattrap January 20, 2023 13:14
@VargaElod23 VargaElod23 self-assigned this Jan 20, 2023
@VargaElod23 VargaElod23 marked this pull request as draft January 20, 2023 13:14
@VargaElod23 VargaElod23 marked this pull request as ready for review January 20, 2023 16:08
@VargaElod23 VargaElod23 linked an issue Jan 23, 2023 that may be closed by this pull request
[ERC-20-INFO-API] Add shared cache config to API Taraxa-project/taraxa-platform#346
Closed
@VargaElod23 VargaElod23 changed the title WIP: adds try to integrate shared cache, lib errors Integrates shared cache, lib errors Jan 25, 2023
rattrap
rattrap reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@rattrap rattrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the cache manager class directly and update all of the sensitive values at the same time.
If any call fails, we don't update the value.

charts/taraxa-info-api/templates/configmap.yaml Outdated Show resolved Hide resolved
src/node/node.module.ts Outdated Show resolved Hide resolved
rattrap
rattrap reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@rattrap rattrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the uppercase endpoints (ex: AVC) to lowercase

rattrap
rattrap approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@rattrap rattrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rattrap
rattrap requested changes Jan 26, 2023
View reviewed changes
src/token/token.service.ts Outdated Show resolved Hide resolved
rattrap
rattrap requested changes Jan 27, 2023
View reviewed changes
src/token/token.service.ts Show resolved Hide resolved
.env.dist Outdated Show resolved Hide resolved
@Taraxa-project Taraxa-project deleted a comment from Elod23 Jan 27, 2023
rattrap
rattrap requested changes Jan 30, 2023
View reviewed changes
.gitignore Outdated
/charts/taraxa-info-api/prod.secret.values.yaml

src/routes.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this.

charts/taraxa-info-api/prod.values.yaml
@@ -9,6 +9,9 @@ app:
coingeckoUri: https://api.coingecko.com/api/v3/simple/price?ids=taraxa&vs_currencies=usd
testnetExplorerUri: https://explorer.testnet.taraxa.io
mainnetExplorerUri: https://explorer.mainnet.taraxa.io
redisHost: 10.39.114.21
redisPort: 6379
redisName: infocache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a password as the production redis is password-protected.

package.json Outdated
"ethers": "^5.3.1",
"fs": "^0.0.1-security",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this.

src/main.ts Outdated
@@ -1,6 +1,7 @@
import { NestFactory } from '@nestjs/core';
import { DocumentBuilder, SwaggerModule } from '@nestjs/swagger';
import { AppModule } from './app.module';
import * as fs from 'fs';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this.

@rattrap rattrap merged commit 16abe18 into main Jan 30, 2023
@rattrap rattrap deleted the feature/enable-common-cache branch January 30, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rattrap rattrap rattrap approved these changes

Assignees

@VargaElod23 VargaElod23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ERC-20-INFO-API] Add shared cache config to API
3 participants
@VargaElod23 @rattrap @Elod23