Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created SDK package and move community networks file to it #582

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Created SDK package and move community networks file to it #582

wants to merge 12 commits into from

Conversation

Malak67
Copy link
Contributor

@Malak67 Malak67 commented Sep 22, 2023

Closes #569

VargaElod23
VargaElod23 requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@VargaElod23 VargaElod23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions added

packages/taraxa-sdk/.eslintrc.js Show resolved Hide resolved
packages/taraxa-sdk/.eslintrc.js Show resolved Hide resolved
packages/taraxa-sdk/package.json Show resolved Hide resolved
services/explorer/src/hooks/useExplorerNetwork.tsx Outdated Show resolved Hide resolved
services/explorer/src/pages/Nodes/Nodes.tsx Outdated Show resolved Hide resolved
services/explorer/tsconfig.json Outdated Show resolved Hide resolved
@Malak67 Malak67 requested a review from VargaElod23 October 16, 2023 09:42
VargaElod23
VargaElod23 previously approved these changes Oct 16, 2023
View reviewed changes
rattrap
rattrap requested changes Oct 23, 2023
View reviewed changes
packages/taraxa-sdk/rollup.config.js Outdated Show resolved Hide resolved
@Malak67 Malak67 requested a review from rattrap October 23, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rattrap rattrap rattrap approved these changes

@VargaElod23 VargaElod23 VargaElod23 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK] Create minimal taraxa-sdk package
3 participants
@Malak67 @rattrap @VargaElod23