TSK-1709: optimized other mockStatic calls to match recommendation

which is to use mockStatic together with a try-with-resources statement
Taskana · Aug 19, 2021 · 3812e9e · 3812e9e
1 parent 9d329c5
commit 3812e9e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/...na-common-logging/src/test/java/pro/taskana/common/internal/logging/LoggingTestClass.java b/...na-common-logging/src/test/java/pro/taskana/common/internal/logging/LoggingTestClass.java
@@ -2,9 +2,7 @@
 
 class LoggingTestClass {
 
-  public void logInternalMethod() {
-    System.out.println("PENIS");
-  }
+  public void logInternalMethod() {}
 
   @SuppressWarnings("UnusedReturnValue")
   public String logInternalMethodWithReturnValue() {

diff --git a/lib/taskana-core/src/test/java/acceptance/task/QueryTasksAccTest.java b/lib/taskana-core/src/test/java/acceptance/task/QueryTasksAccTest.java
@@ -136,14 +136,15 @@ void testQueryTaskValuesForColumnNameOnAttachments() {
   @WithAccessId(user = "admin")
   @Test
   void should_SplitTaskListIntoChunksOf32000_When_AugmentingTasksAfterTaskQuery() {
-    MockedStatic<CollectionUtil> listUtilMock = Mockito.mockStatic(CollectionUtil.class);
-    listUtilMock
-        .when(() -> CollectionUtil.partitionBasedOnSize(any(), anyInt()))
-        .thenCallRealMethod();
+    try (MockedStatic<CollectionUtil> listUtilMock = Mockito.mockStatic(CollectionUtil.class)) {
+      listUtilMock
+          .when(() -> CollectionUtil.partitionBasedOnSize(any(), anyInt()))
+          .thenCallRealMethod();
 
-    TASK_SERVICE.createTaskQuery().list();
+      TASK_SERVICE.createTaskQuery().list();
 
-    listUtilMock.verify(() -> CollectionUtil.partitionBasedOnSize(any(), eq(32000)));
+      listUtilMock.verify(() -> CollectionUtil.partitionBasedOnSize(any(), eq(32000)));
+    }
   }
 
   @WithAccessId(user = "admin")