Closes #2404 - Upgrade to Spring Boot 3.1.5 #2428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to Spring Boot 3.1.x required an upgrade to jakarta.
The Wildfly server 25.0.1 does not yet support jakarta, so it had to be upgraded as well.
With Spring Boot 3.1.X, SLF4J 2.0.X was also added to TASKANA.
We tried to adapt as little production & test code as possible, except for the imports.
However, this was not possible in the CDI module.
Here a new method with an empty body had to be implemented so that the PostConstruct method is executed first.
is executed first.
The other changes in the CDI module concern the switch to Wildfly 27 and the upgrade of the arquillian test module.
After reviewing the sonar-cloud results, I switched from property injection to constructor injection for all cdi related classes.
The taskana-routing-rest module could no longer be built because it had a dependency on the dmn-xlsx-converter from camunda. This community project has not yet been updated to jakarta. So we cloned dmn-xlsx-converter and built it as a submodule of taskana-routing-parent.
We made all necessary changes available to the project as PR and documented them in the clone.
SonarCloud results
https://sonarcloud.io/summary/new_code?id=norman-schmidt_taskana&branch=SPRING_BOOT_3_1_x
All warnings regarding the dmn-xlsx-converter will not be fixed for the time being. How this will be handled has yet to be decided.
Addendum Nr: 1
In the module taskana-routing-rest I switched from com.sun.xml.bind:jaxb-core to org.glassfish.jaxb:jaxb-core and com.sun.xml.bind:jaxb-impl to org.glassfish.jaxb:jaxb-runtime .
There is already a discussion about this. #2421 (comment)
Should we stay with glassfish here or switch back to sun?
Addendum Nr: 2
While upgrading to Wildfly 27.0.1 I noticed that a complete EE server is started here.
In my opinion this is not necessary.
Changing the configuration of the Wildfly server at this point can speed up testing considerably.
However, this is not part of the Spring Boot upgrade and should be addressed in a separate ticket.
Release Notes:
For the submitter:
Verified by the reviewer: