✨Feat(#152): 내 템플릿 API 1차 연동 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sscoderati
reviewed
Nov 12, 2023
| const { toast } = useToast(); | ||
| const router = useRouter(); | ||
|
|
||
| const validateQuestion = (content: string) => { |
There was a problem hiding this comment.
단순 validation만 담당하는 함수는 아닌 것 같아요!
handleAddQuestion 이라는 네이밍을 제안드립니다!
JIY00N2
approved these changes
Nov 13, 2023
Comment on lines
+93
to
94
| onChange={(e) => handleInputChange(e, item.id)} | ||
| /> |
There was a problem hiding this comment.
저희 컨벤션 중에 event에 대한 네이밍은 e 보다는 event로 쓰기로 했습니당!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 구현 사항
Steady.-.Brave.2023-11-13.00-17-19.mp4
🚧 특이 사항
🚨관련 이슈
close #152