Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Feat(#313): 스테디 상세 페이지에 연락수단 클립보드 기능 추가 #314

Merged
merged 4 commits into from
Dec 2, 2023

Conversation

JIY00N2
Copy link
Member

@JIY00N2 JIY00N2 commented Dec 1, 2023

📑 구현 사항

  • 스테디 상세 페이지에 연락수단 클립보드 기능을 추가했습니다.
_2023_12_01_18_03_11_309.mp4

🚧 특이 사항

🚨관련 이슈

close #313

@JIY00N2 JIY00N2 added 기능 새로운 기능! 🚨 D-0 당일 리뷰 부탁드립니다! labels Dec 1, 2023
@JIY00N2 JIY00N2 added this to the 6차 스프린트 milestone Dec 1, 2023
@JIY00N2 JIY00N2 self-assigned this Dec 1, 2023
@JIY00N2 JIY00N2 linked an issue Dec 1, 2023 that may be closed by this pull request
1 task
Copy link
Member

@sscoderati sscoderati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines -410 to +411
<div className="flex w-full max-lg:flex-col max-lg:gap-10 xl:flex-row">
<div className="grid w-full items-center max-sm:grid-cols-1 max-sm:gap-10 sm:grid-cols-1 sm:gap-10 md:grid-cols-2 md:gap-10 lg:grid-cols-2 lg:gap-25 xl:grid-cols-4">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 배치할 요소가 많아지면 영역을 더 나눠서 flex로 배치하는 것 보다 이렇게 grid를 쓰는 것도 좋은 것 같습니다..!


const copySteadyContact = async (text: string) => {
try {
await navigator.clipboard.writeText(text);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@JIY00N2 JIY00N2 merged commit 09a2490 into main Dec 2, 2023
2 checks passed
@JIY00N2 JIY00N2 deleted the feat/#313/detail-clipboard branch December 2, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 새로운 기능! 🚨 D-0 당일 리뷰 부탁드립니다!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] - 상세 페이지 연락 수단 클립 보드 구현
2 participants