Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#108 fix news UI #110

Merged
merged 14 commits into from
Nov 22, 2024
Merged

Feature/#108 fix news UI #110

merged 14 commits into from
Nov 22, 2024

Conversation

Eonji-sw
Copy link
Member

@Eonji-sw Eonji-sw commented Nov 21, 2024

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • news ์ƒ๋‹จ๋ฐ” UI์ˆ˜์ •
  • news ํƒญ UI ์ˆ˜์ •

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

2024-11-21.9.48.51.mov

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

์†Œ์‹์„ ์ด๋ฏธ news๋กœ ๋„ค์ด๋ฐ์ง€์–ด ์‚ฌ์šฉํ•ด์„œ.. ์†Œ์‹ ํƒญ ๋‰ด์Šค์™€ ์˜์–ด ๋„ค์ด๋ฐ์ด ๊ฒน์ณ์š” ใ…œใ…œ
์ˆ˜์ •ํ•˜๊ธฐ์—” ๋Œ€๊ณต์‚ฌ๋ผ ์ผ๋‹จ ๋‘˜๋‹ค news๋กœ ๋„ค์ด๋ฐํ•œ.....,,,

@Eonji-sw Eonji-sw added โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ ๐Ÿ’Ÿย [UI] UI ์ž‘์—… xml ํŒŒ์ผ ๊ฑด๋“ค๋ฉด ์š”๊ฑฐ ๐Ÿฐ ์–ธ์ง€ ๊ธฐ๋งŒ์ง€ labels Nov 21, 2024
@Eonji-sw Eonji-sw self-assigned this Nov 21, 2024
Copy link
Collaborator

@sohyun127 sohyun127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gooood ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค :>

  • ์œ„์— ํˆด ๋ฐ” ๋กœํ‹ฐ ์ž์ฒด์— 2px์ •๋„ ํฐ์ƒ‰ ์—ฌ๋ฐฑ์ด ์žˆ์Šต๋‹ˆ๋‹ค. ๋””์ž์ธ ์„ ์ƒ๋‹˜ํ•œํ…Œ ๊ฒ€์ • ์—ฌ๋ฐฑ ๋“ค์–ด๊ฐ„ ๋กœํ‹ฐ ๋‹ฌ๋ผ๊ณ  ํ•ด์„œ ๋ณ€๊ฒฝํ•ด์•ผํ•ด์š”.
  • news์™€ news์˜ ๋„ค์ด๋ฐ์€ ^^ ๊ณ ๋ฏผํ•ด๋ณด์ฃ 

์ˆ˜์ • ์‚ฌํ•ญ ๋ฐ˜์˜ ํ›„ ๋จธ์ง€ please

Copy link
Collaborator

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ฐœ์ถ”ํฌ๋ ˆ์šฉ

@Eonji-sw Eonji-sw merged commit ff32d25 into develop Nov 22, 2024
1 check passed
@Eonji-sw Eonji-sw deleted the feature/#108-fix-news-ui branch November 22, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿฐ ์–ธ์ง€ ๊ธฐ๋งŒ์ง€ ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ ๐Ÿ’Ÿย [UI] UI ์ž‘์—… xml ํŒŒ์ผ ๊ฑด๋“ค๋ฉด ์š”๊ฑฐ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] : news ์ƒ๋‹จ๋ฐ” + ํƒญ UI ์ˆ˜์ •
3 participants