Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#111 news notice UI #116
Feature/#111 news notice UI #116
Changes from all commits
5b6aff1
868bab3
950f8aa
fc03e98
b19fa3d
450ef39
ec4ece9
3cd6473
2d44674
fe301f9
1bd1218
feb72eb
83d3762
ffe67cb
5d0b78d
9e3d9da
5f66b8d
3a9a158
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ parent๊ฑฐ ๊ฐ์ ธ์ค๋ ๋ฒ์ ์ฒ์์์๋ค์ ์งฑ!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํ๋์ด๋ค๊ฐ.. ์ฌ์ฉํด๋ณด์์ด๋ค
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p1 :์ด๊ฑด ์ถํ์ ์๋ฒํต์ ํ๋ฉด์ state๋ฅผ collectํ๋ ๋ฐฉ์์ผ๋ก ๋ฐ๊พธ์ด์ฃผ์ธ์!
val showEmptyText by viewModel.showDialog.collectAsStateWithLifecycle()
์ด๋ฐ์์ผ๋ก์! ๋ค์ด๋ฐ์ ์์๋ฑ๊ฐ์ผ์ผ๋ก~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ง๊ธ ๊ตฌ์กฐ์์๋ List์ ๊ฐ์ ์ง์ ๊ฐ์ ธ์ค๋ ์์ธ๋ฐ
์ปดํฌ์ ๋ธ์์๋ List์ ๊ฒฝ์ฐ unstatble๋ก ๊ฐ์ฃผ( ์๋๋ฉด list๋ ๊ฐ์ ๋ณ๊ฒฝํ ์ ์์ผ๋๊น MutableList๋ฅผ ๋ฃ์์ ์๊ธฐ๋๋ฌธ) ๋๊ธฐ์ ๋ฆฌ์ปดํฌ์ง์ ์ ์์ธ์ด ๋ฉ๋๋ค!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ImmutableList์ PersistentList๋ฅผ ์ฌ์ฉ๊ฐ๋ฅํ๋๋ก ๋ผ์ด๋ธ๋ฌ๋ฆฌ๋ฅผ ์ค์น ํด๋์์ต๋๋ค~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋น ์๋ฒํต์ ํ ๋ ์ ์ฉํด๋ณผ๊ฒ์ฉ ^.<