[Feature/#115] news news UI + api연결(페이징) #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanubc
requested review from
a team,
Eonji-sw and
sohyun127
and removed request for
a team
Eonji-sw
approved these changes
Nov 25, 2024
| contentAlignment = Alignment.Center, | ||
| ) { | ||
| Image( | ||
| imageVector = toImageVector(com.teamwable.common.R.drawable.iv_share_loading_spinner), |
| @@ -88,3 +89,6 @@ fun Modifier.dropShadow( | |||
| canvas.restore() | |||
| } | |||
| } | |||
|
|
|||
| fun Modifier.showIf(condition: Boolean): Modifier = | |||
| @SerialName("newsText") | ||
| val newsText: String, | ||
| @SerialName("newsImage") | ||
| val newsImage: String, |
There was a problem hiding this comment.
헉 이미지 없는경우는 고려를 못했네요 으아아아아아 ui도다시짜야 되네 감사래요
Comment on lines
+102
to
+103
| isLoading -> item { LoadingScreen() } | ||
| isEmpty -> item { NewsNoticeEmptyScreen(emptyTxt = R.string.tv_news_info_empty) } |
| WablePagingSpinner( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(vertical = 16.dp), |
There was a problem hiding this comment.
P3 : compose는 dimen에 있는 값 사용 못하나요?
|
나머지는 다음 pr에서 반영할께요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
KakaoTalk_20241125_025513065.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
우선 공통적으로 쓰이는
우선 공통으로 쓰이는 data model에서 newsId를 Long타입으로 변경하였습니다! genercSource가 Long을 받도록 설정되어잇어서요
로딩스크린, 엠티뷰스크린은 designsystem-screen 으로 옮겨 놓았습니다!
그리고 언지님이 기존에 만든 엠티뷰 스크린에서 modifer에 aspectRatio(1f) 추가 했는데 ui 깨지거나 하면 말씀해주세요!
상태관리에 고민이 좀 많았는데 일단 header달린 멀티뷰 타입이라 lazyColumn내부에 넣었습니다.
공지사항 화면 같은경우는 로딩이나 엠티의 경우 상위 컴포저블에서 조금 더 깔끔하게 상태 처리 할 수 있을것 같아요!
추가로 5분전 -> 이거는
이런식으로 만들었는데 이전 버전에서 안돌아가긴 할거에요ㅠ
그리고 로드가 너무 빨리되서 delay 2초 정도 걸고 테스트 했습니다.