Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#117 news notice api paging #120

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Feature/#117 news notice api paging #120

merged 15 commits into from
Nov 25, 2024

Conversation

Eonji-sw
Copy link
Member

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • paging ์—ฐ๊ฒฐ
  • ๊ณต์ง€์‚ฌํ•ญ ๋ชฉ๋ก ์กฐํšŒ api ์—ฐ๊ฒฐ
  • ์ƒํƒœ๋ฐ” mode ์ ์šฉ

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

2024-11-25.5.46.24.mov

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

์ฐฌ์šฐํ–„์ด ํ•œ ์ฝ”๋“œ ๊ฐ€์ ธ๋‹ค ์“ฐ๊ธฐ๋งŒ ํ–‡์Šˆ ใ…‹ใ…‹

@Eonji-sw
#117 [FEAT] : statusBarModeOf ํ™•์žฅํ•จ์ˆ˜ ๊ตฌํ˜„
dc13961
@Eonji-sw
#117 [MOD] : statusBarModeOf ํ™•์žฅํ•จ์ˆ˜ ์ ์šฉ
8321321
@Eonji-sw
Merge remote-tracking branch 'origin/develop' into feature/#117-news-โ€ฆ
e3f28f0 
โ€ฆnotice-api-paging
@Eonji-sw
#117 [FEAT] : repository impl getNoticeInfo ๊ตฌํ˜„
457f97e
@Eonji-sw
#117 [MOD] : ๋žŒ๋‹ค ์ˆ˜์ •
b0073b5
@Eonji-sw
#117 [MOD] : ์ธ์ž ๋„ค์ด๋ฐ ๋ฐ ๋ณ€๊ฒฝ
96de400
@Eonji-sw
#117 [FEAT] : news notice paging api ์—ฐ๊ฒฐ
03ff869
@Eonji-sw
#117 [FEAT] : news notice viewModel ๊ตฌํ˜„
2553349
@Eonji-sw
#117 [FEAT] : repository getNoticeInfo ๊ตฌํ˜„
3439010
@Eonji-sw
#117 [FEAT] : service getNoticeInfo ๊ตฌํ˜„
a00b1c3
@Eonji-sw
#117 [MOD] : ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ ์ œ๊ฑฐ
c54505f
@Eonji-sw
#117 [FEAT] : mapper toNoticeInfoModel ๊ตฌํ˜„
3292fc3
@Eonji-sw
#117 [FEAT] : dto ResponseNoticeInfoDto ๊ตฌํ˜„
ecb6984
@Eonji-sw Eonji-sw added โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿฐ ์–ธ์ง€ ๊ธฐ๋งŒ์ง€ โ˜• [COMPOSE] ์ปดํฌ์ฆˆ ui labels Nov 25, 2024
@Eonji-sw Eonji-sw self-assigned this Nov 25, 2024
chanubc
chanubc approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goooooD! ์—ญ์‹œ ํ”Œ๋Ÿฌํ„ฐ๋ฅผ ํ•ด์„œ ์ž˜ํ•˜์‹œ๋„ค์š”
๋‚จ์€ ์‚ฌ๊ณผ ๋ฐ˜์ชฝ๋„ ์–ผ๋ฅธ ์ฐพ์œผ์‹œ๊ธธ ๋ฐ”๋ž๋‹ˆ๋‹ค

core/ui/src/main/java/com/teamwable/ui/extensions/FragmentExt.kt Show resolved Hide resolved
feature/news/src/main/java/com/teamwable/news/notice/NewsNoticeRoute.kt Outdated Show resolved Hide resolved
sohyun127
sohyun127 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@sohyun127 sohyun127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๐Ÿ‘

core/ui/src/main/java/com/teamwable/ui/extensions/FragmentExt.kt Show resolved Hide resolved
@Eonji-sw Eonji-sw merged commit f9366a1 into develop Nov 25, 2024
1 check passed
@Eonji-sw Eonji-sw deleted the feature/#117-news-notice-api-paging branch November 25, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanubc chanubc chanubc approved these changes

@sohyun127 sohyun127 sohyun127 approved these changes

Assignees

@Eonji-sw Eonji-sw

Labels
โ˜• [COMPOSE] ์ปดํฌ์ฆˆ ui โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿฐ ์–ธ์ง€ ๊ธฐ๋งŒ์ง€
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] : News ํŽ˜์ด์ง€ Notice ํƒญ API ๊ตฌํ˜„
3 participants
@Eonji-sw @sohyun127 @chanubc