[Feature/#119] news detail #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanubc
requested review from
Eonji-sw and
sohyun127
and removed request for
a team
chanubc
added
โญ [FEAT]
sohyun127
approved these changes
Nov 26, 2024
| @@ -220,6 +224,22 @@ class MainActivity : AppCompatActivity(), Navigation { | |||
| } | |||
| } | |||
|
|
|||
| private fun updateStatusBarColor(navController: NavController) { | |||
There was a problem hiding this comment.
์ง๊ธ ์๊ฐํด๋ณด๋ status bar๋ activity์ ์ฑ ์์ด๋ main activity์์ ๊ด๋ฆฌํ๋๊ฒ ๋ ์ข์๋ณด์ด๋ค์! ๐
|
|
||
| class NewsDetailFragment : BindingFragment<FragmentNewsDetailBinding>(FragmentNewsDetailBinding::inflate) { | ||
| private val args: NewsDetailFragmentArgs by navArgs() | ||
| private val notice: NewsInfoModel by lazy { args.newsInfoModel } |
There was a problem hiding this comment.
์น ์ง์ฐ ์ด๊ธฐํ ํ์ จ๊ตฐ์
There was a problem hiding this comment.
์ฌ์ค initView()์์ ํ์ด๋ ์๊ด์๊ธดํด์ใ
# Conflicts: # feature/news/src/main/java/com/teamwable/news/NewsTabType.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
โ ๐๐ต๐ฒ๐ฐ๐ธ-๐๐ถ๐๐
๐ ๐๐๐๐๐ฒ๐
๐๐ช๐ผ๐ฟ๐ธ ๐๐ฒ๐๐ฐ๐ฟ๐ถ๐ฝ๐๐ถ๐ผ๐ป
๐ท ๐ฆ๐ฐ๐ฟ๐ฒ๐ฒ๐ป๐๐ต๐ผ๐
KakaoTalk_20241126_043927695.mp4
๐ฌ ๐ง๐ผ ๐ฅ๐ฒ๐๐ถ๐ฒ๐๐ฒ๐ฟ๐
์ํ๋ฐ๊ฐ detail ํ๋ฉด์์ white์์ ๋ณํ์ง ์์์ MainActivity๋ก ๋ก์ง ์์ ํ์ต๋๋ค!
fragment์ ๋ผ์ดํ์ฌ์ดํด ์ ์ ๊ฐ ์๊ตฐ์.. ์ ์๊ฐ์ fragment์์ activity์ context์ ์ ๊ทผํ์ฌ ์์คํ ui ์์ ์ด ์๋ช ์ฃผ๊ธฐ์ ๋จ์ ์๋๊ฒ ๊ฐ์ต๋๋ค