Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/#123] : select by version, force update #126

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

sohyun127
Copy link
Collaborator

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • ๋ฒ„์ „๋ณ„ ์„ ํƒ, ๊ฐ•์ œ ์—…๋ฐ์ดํŠธ ๋ถ„๊ธฐ์ฒ˜๋ฆฌ (a.b.c ์ค‘ a๋‚˜ b๊ฐ€ ๋ณ€ํ•˜๋ฉด ๊ฐ•์ œ)
  • ๊นŒ๋จน๊ณ  ์žˆ์—ˆ๋˜ ๊ธฐ๋Šฅ ์ถ”๊ฐ€..
    • ๋Œ“๊ธ€์— ๋งํฌ ์ฒจ๋ถ€ ๊ฐ€๋Šฅํ•˜๋„๋ก ์ˆ˜์ •
    • home feed์—์„œ ๋Œ“๊ธ€ ์•„์ด์ฝ˜ ํด๋ฆญ ์‹œ home detail๋กœ ์ด๋™ํ•˜๋„๋ก ์ˆ˜์ •
  • fcm ํ—ˆ์šฉ ์•ˆ ํ•จ ๋ถ„๊ธฐ ์ฒ˜๋ฆฌ ๋กœ์ง ์ˆ˜์ •
    • requestPermission ์—์„œ false ๋ถ„๊ธฐ๊ฐ€ ๋‹ค์ด์–ผ๋กœ๊ทธ์˜ ํ—ˆ์šฉ ์•ˆํ•จ ๋ถ„๊ธฐ์ธ ์ค„ ์•Œ์•˜๋Š”๋””.. ํ—ˆ์šฉ ์•ˆ ํ–ˆ์„ ๋•Œ ์ง€์†์ ์œผ๋กœ ํ•ด๋‹นํ•˜๋Š” ๋ถ„๊ธฐ๋”๋ผ๊ตฌ์š”.. ๋ถˆํ•„์š”ํ•œ api call ์žˆ์–ด์„œ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. 462bf30

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

์„ ํƒ ์—…๋ฐ์ดํŠธ ์ผ ๋•Œ

KakaoTalk_20241126_164240575.mp4

๊ฐ•์ œ ์—…๋ฐ์ดํŠธ ์ผ ๋•Œ

KakaoTalk_20241126_164238832.mp4

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

@sohyun127 sohyun127 added โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ ๐Ÿฑ ์†Œํ˜„ ๋ฆฌ๋‚˜ labels Nov 26, 2024
@sohyun127 sohyun127 requested review from a team, Eonji-sw and chanubc and removed request for a team November 26, 2024 07:49
Copy link
Collaborator

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ธํ•œ ๊ฐ•์ œ ์—…๋ฐ์ดํŠธ!

Comment on lines +31 to +34
val isFirstCodeDifferent = (BuildConfig.VERSION_CODE / 100) != (appUpdateInfo.availableVersionCode() / 100)
val isSecondCodeDifferent = ((BuildConfig.VERSION_CODE % 100) / 10) != ((appUpdateInfo.availableVersionCode() % 100) / 10)
return isFirstCodeDifferent || isSecondCodeDifferent
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค ์ด ์ฝ”๋“œ๋Š” ๋ญ”๊ฐ€์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฒ„์ „ ์ฝ”๋“œ abc์ผ ๋•Œ ์‹ ๊ทœ ๋ฒ„์ „๊ณผ ๊ธฐ์กด ๋ฒ„์ „์˜ a, b ๋‹ค๋ฅด๋ฉด ๊ฐ•์ œ ์—…๋ฐ์ดํŠธ๋กœ ํŒ๋ณ„ํ•˜๋Š” ๋กœ์ง์ž…๋‹ˆ๋‹ค!
๋ฒ„์ „ ์ฝ”๋“œ๊ฐ€ int ํ˜•ํƒœ๋ผ์„œ ์ด๋ ‡๊ฒŒ ์ฒ˜๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค~!

@sohyun127 sohyun127 merged commit b8124da into develop Nov 26, 2024
1 check passed
@sohyun127 sohyun127 deleted the feature/#123-version-update branch November 26, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿฑ ์†Œํ˜„ ๋ฆฌ๋‚˜ ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ
Projects
None yet
2 participants