Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#128 qa fix #129

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Feature/#128 qa fix #129

merged 6 commits into from
Nov 27, 2024

Conversation

Eonji-sw
Copy link
Member

@Eonji-sw Eonji-sw commented Nov 27, 2024

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • ๊ธ€ ์ž‘์„ฑ ๋‚ด์šฉ textappearance ๋ณ€๊ฒฝ
  • ์†Œ์‹ ๊ณต์ง€์‚ฌํ•ญ img ์กฐ๊ฑด ์ œ๊ฑฐ
  • ์•Œ๋ฆผ comment ๋ถ„๊ธฐ์ฒ˜๋ฆฌ ๊ตฌํ˜„

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

2024-11-27.9.08.29.mov

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

@Eonji-sw Eonji-sw added โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ ๐Ÿ’Ÿย [UI] UI ์ž‘์—… xml ํŒŒ์ผ ๊ฑด๋“ค๋ฉด ์š”๊ฑฐ ๐Ÿš‘๏ธย [HOTFIX] ์ด์Šˆ๋‚˜ QA์—์„œ ๋ฐœ์ƒ๋œ ๊ธ‰ํ•˜๊ฒŒ ํ•ด๊ฒฐํ•ด์•ผ ๋  ๋ฌธ์ œ ๐Ÿฐ ์–ธ์ง€ ๊ธฐ๋งŒ์ง€ labels Nov 27, 2024
@Eonji-sw Eonji-sw self-assigned this Nov 27, 2024
Copy link
Collaborator

@sohyun127 sohyun127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๐Ÿ‘

@@ -123,6 +123,7 @@
android:hint="@string/hint_posting_content"
android:importantForAutofill="no"
android:maxLength="500"
android:textAppearance="@style/TextAppearance.Wable.Body2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹์ด๊ฑธ ๋นผ๋จน๋‹ค๋‹ˆ!!

Copy link
Collaborator

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค!

@Eonji-sw Eonji-sw merged commit ee6df64 into develop Nov 27, 2024
1 check passed
@Eonji-sw Eonji-sw deleted the feature/#128-qa-fix branch November 27, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿฐ ์–ธ์ง€ ๊ธฐ๋งŒ์ง€ ๐Ÿ”จย [FIX] ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ๋ฐœ์ƒ ๋ฐ ํ•ด๊ฒฐ ๐Ÿš‘๏ธย [HOTFIX] ์ด์Šˆ๋‚˜ QA์—์„œ ๋ฐœ์ƒ๋œ ๊ธ‰ํ•˜๊ฒŒ ํ•ด๊ฒฐํ•ด์•ผ ๋  ๋ฌธ์ œ ๐Ÿ’Ÿย [UI] UI ์ž‘์—… xml ํŒŒ์ผ ๊ฑด๋“ค๋ฉด ์š”๊ฑฐ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HOTFIX] : qa ๋ฐ˜์˜
3 participants