Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/#132] : add new amplitude tag #133

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[Feature/#132] : add new amplitude tag #133

merged 2 commits into from
Nov 28, 2024

Conversation

sohyun127
Copy link
Collaborator

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • ์ƒˆ๋กœ ์ถ”๊ฐ€๋œ amplitude tag ์‹ฌ์—ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

N/A

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

@sohyun127 sohyun127 added โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿฑ ์†Œํ˜„ ๋ฆฌ๋‚˜ labels Nov 28, 2024
@sohyun127 sohyun127 requested review from a team, Eonji-sw and chanubc and removed request for a team November 28, 2024 03:55
chanubc
chanubc approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTTTM ๐Ÿฅ‡

@sohyun127 sohyun127 merged commit 6bd117b into develop Nov 28, 2024
1 check passed
@sohyun127 sohyun127 deleted the feature/#132-amplitude-tag branch November 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanubc chanubc chanubc approved these changes

@Eonji-sw Eonji-sw Awaiting requested review from Eonji-sw Eonji-sw was automatically assigned from Team-Wable/wable-android

Assignees

@sohyun127 sohyun127

Labels
โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿฑ ์†Œํ˜„ ๋ฆฌ๋‚˜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] : amplitude ์ด๋ฒคํŠธ ํƒœ๊ทธ ์‹ฌ๊ธฐ
2 participants
@sohyun127 @chanubc