Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix/#94] : team tag color #98

Merged
merged 22 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1a8966a
#94 [FIX] : change home tab lottie height, add home empty view
sohyun127 Oct 9, 2024
c958025
#94 [FEAT] : add home empty view
sohyun127 Oct 9, 2024
a1e08be
#94 [MOD] : remove unnecessary permission
sohyun127 Oct 9, 2024
5cc4caf
#91 [mod] : compose 버전 μ—…
chanubc Oct 7, 2024
63c44d9
#91 [add] : add compose navigation, model dependency in navigation mo…
chanubc Oct 7, 2024
ed47fe4
#91 [add] : add serialization dependency in model module
chanubc Oct 7, 2024
04e47c3
#91 [feat]: Add CustomNavType to support generic types
chanubc Oct 7, 2024
8d00b42
#91 [delete]: delete unused enum type
chanubc Oct 7, 2024
6161a5b
#91 [mod]: change route parameter type list to custom data class
chanubc Oct 7, 2024
5a54238
#91 [refactor] : Change lambda parameters List to data class
chanubc Oct 7, 2024
6748f66
#91 [refactor] : Refactor navigation lambdas to method reference
chanubc Oct 7, 2024
1f01cdb
#91 [add] : Add @Serializable annotation in MemberInfoEditModel
chanubc Oct 7, 2024
a0f493c
#91 [mod] : use custom nav type and change navcontroller parameter to…
chanubc Oct 7, 2024
9da7f85
#91 [mod] : nav args κ°’ MemberInfoEditModel 객체둜 데이터 처리 톡일 및 μƒνƒœ 관리 κ°„μ†Œν™”
chanubc Oct 7, 2024
25c1942
#91 [fix] : μ„œλ²„ dbμ΄ˆκΈ°ν™” μ‹œ, IsNewUserμ—μ„œ nickname으둜 checkIsNewUser νŒλ³„
chanubc Oct 7, 2024
ad4e190
#91 [chore] : λΆˆν•„μš”ν•œ μ½¬λ“œ 제거
chanubc Oct 7, 2024
8d472fd
#91 [refactor] : refactor CustomNavType using parcelable
chanubc Oct 7, 2024
f0f3e1f
#91 [chore] : delete unused code
chanubc Oct 7, 2024
8b4f413
#94 [UI] : change dk team tag color
sohyun127 Oct 9, 2024
2a453c6
#94 [FEAT] : change rank season text (temp)
sohyun127 Oct 10, 2024
76c91a4
#94 [FIX] : fix binding error
sohyun127 Oct 11, 2024
9c37662
Merge branch 'develop' of https://github.com/Team-Wable/WABLE-ANDROID…
sohyun127 Oct 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />

<uses-permission android:name="android.permission.READ_PHONE_STATE" />
<uses-permission android:name="com.google.android.gms.permission.AD_ID" />

<application
android:name=".WableApp"
Expand Down
2 changes: 1 addition & 1 deletion core/common/src/main/res/raw/tab_lottie.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"nm":"Main Scene","ddd":0,"h":4,"w":360,"meta":{"g":"@lottiefiles/creator 1.22.0"},"layers":[{"ty":4,"nm":"Rectangle 1","sr":1,"st":0,"op":150,"ip":0,"hd":false,"ddd":0,"bm":0,"hasMask":false,"ao":0,"ks":{"a":{"a":0,"k":[0.5,0]},"s":{"a":0,"k":[100,100]},"sk":{"a":0,"k":0},"p":{"a":0,"k":[180.5,1]},"r":{"a":0,"k":0},"sa":{"a":0,"k":0},"o":{"a":0,"k":100}},"shapes":[{"ty":"rc","bm":0,"hd":false,"nm":"Rectangle Path 1","d":1,"p":{"a":0,"k":[0,0]},"r":{"a":0,"k":0},"s":{"a":0,"k":[360,2]}},{"ty":"gf","bm":0,"hd":false,"nm":"Fill","e":{"a":0,"k":[188,0]},"g":{"p":2,"k":{"a":1,"k":[{"o":{"x":0.167,"y":0.167},"i":{"x":0.833,"y":0.833},"s":[0,0.5607843137254902,0.29411764705882354,1,1,0.00784313725490196,0.9137254901960784,0.8117647058823529],"t":0},{"o":{"x":0.167,"y":0.167},"i":{"x":0.833,"y":0.833},"s":[0,0.00784313725490196,0.9137254901960784,0.8117647058823529,1,0.5607843137254902,0.29411764705882354,1],"t":60},{"s":[0,0.5607843137254902,0.29411764705882354,1,1,0.00784313725490196,0.9137254901960784,0.8117647058823529],"t":120}]}},"t":1,"a":{"a":0,"k":0},"h":{"a":0,"k":0},"s":{"a":0,"k":[-188,0]},"r":2,"o":{"a":0,"k":100}}],"ind":1}],"v":"5.7.0","fr":30,"op":120,"ip":0,"assets":[]}
{"nm":"Main Scene","ddd":0,"h":4,"w":360,"meta":{"g":"@lottiefiles/creator 1.25.0"},"layers":[{"ty":4,"nm":"Rectangle 1","sr":1,"st":0,"op":150,"ip":0,"hd":false,"ddd":0,"bm":0,"hasMask":false,"ao":0,"ks":{"a":{"a":0,"k":[0,0]},"s":{"a":0,"k":[100,100]},"sk":{"a":0,"k":0},"p":{"a":0,"k":[180,3]},"r":{"a":0,"k":0},"sa":{"a":0,"k":0},"o":{"a":0,"k":100}},"shapes":[{"ty":"rc","bm":0,"hd":false,"nm":"Rectangle Path 1","d":1,"p":{"a":0,"k":[0,0]},"r":{"a":0,"k":0},"s":{"a":0,"k":[360,2]}},{"ty":"gf","bm":0,"hd":false,"nm":"Fill","e":{"a":0,"k":[188,0]},"g":{"p":2,"k":{"a":1,"k":[{"o":{"x":0.167,"y":0.167},"i":{"x":0.833,"y":0.833},"s":[0,0.5607843137254902,0.29411764705882354,1,1,0.00784313725490196,0.9137254901960784,0.8117647058823529],"t":0},{"o":{"x":0.167,"y":0.167},"i":{"x":0.833,"y":0.833},"s":[0,0.00784313725490196,0.9137254901960784,0.8117647058823529,1,0.5607843137254902,0.29411764705882354,1],"t":60},{"s":[0,0.5607843137254902,0.29411764705882354,1,1,0.00784313725490196,0.9137254901960784,0.8117647058823529],"t":120}]}},"t":1,"a":{"a":0,"k":0},"h":{"a":0,"k":0},"s":{"a":0,"k":[-188,0]},"r":2,"o":{"a":0,"k":100}}],"ind":1}],"v":"5.7.0","fr":30,"op":120,"ip":0,"assets":[]}
4 changes: 2 additions & 2 deletions core/ui/src/main/res/values/colors.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
<color name="bro_10">#FFE3EAE7</color>
<color name="drx_50">#FF1004A4</color>
<color name="drx_10">#FFE4E3F3</color>
<color name="dk_50">#FF4A4A4A</color>
<color name="dk_10">#FFEDEDED</color>
<color name="dk_50">#FF4F5551</color>
<color name="dk_10">#FFE0F7E7</color>
<color name="kt_50">#FFFF0A09</color>
<color name="kt_10">#FFFCE4E4</color>
<color name="fox_50">#FFD31F28</color>
Expand Down
8 changes: 8 additions & 0 deletions feature/home/src/main/java/com/teamwable/home/HomeFragment.kt
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import com.teamwable.ui.extensions.setDividerWithPadding
import com.teamwable.ui.extensions.stringOf
import com.teamwable.ui.extensions.viewLifeCycle
import com.teamwable.ui.extensions.viewLifeCycleScope
import com.teamwable.ui.extensions.visible
import com.teamwable.ui.shareAdapter.FeedAdapter
import com.teamwable.ui.shareAdapter.FeedClickListener
import com.teamwable.ui.shareAdapter.FeedViewHolder
Expand Down Expand Up @@ -179,6 +180,13 @@ class HomeFragment : BindingFragment<FragmentHomeBinding>(FragmentHomeBinding::i
}
}
}

viewLifeCycleScope.launch {
feedAdapter.loadStateFlow.collectLatest { loadStates ->
val isEmptyList = loadStates.refresh is LoadState.NotLoading && feedAdapter.itemCount == 0
binding.tvEmpty.visible(isEmptyList)
}
}
}

private fun setSwipeLayout() {
Expand Down
13 changes: 12 additions & 1 deletion feature/home/src/main/res/layout/fragment_home.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
android:backgroundTint="@color/white"
android:paddingBottom="2dp"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent">
Expand Down Expand Up @@ -71,4 +70,16 @@
app:pressedTranslationZ="0dp"
app:tint="@null" />
</FrameLayout>

<TextView
android:id="@+id/tv_empty"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="아직 μž‘μ„±λœ 글이 μ—†μ–΄μš”."
android:textAppearance="@style/TextAppearance.Wable.Body2"
android:textColor="@color/gray_500"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.teamwable.news.rank

import android.content.Intent
import android.net.Uri
import android.text.Spannable
import android.text.SpannableString
import android.text.style.ForegroundColorSpan
Expand Down Expand Up @@ -37,7 +35,8 @@ class NewsRankFragment : BindingFragment<FragmentNewsRankBinding>(FragmentNewsRa
private fun setupGameTypeObserve() {
viewModel.gameTypeUiState.flowWithLifecycle(viewLifeCycle).onEach {
when (it) {
is UiState.Success -> setSeasonText(it.data)
// μž„μ‹œ ν•˜λ“œ μ½”λ”©
is UiState.Success -> setSeasonText("2024 LCK Summer")
else -> Unit
}
}.launchIn(viewLifeCycleScope)
Expand Down Expand Up @@ -76,7 +75,7 @@ class NewsRankFragment : BindingFragment<FragmentNewsRankBinding>(FragmentNewsRa
spannableString.setSpan(
ForegroundColorSpan(colorOf(com.teamwable.ui.R.color.sky_50)),
16, spannableString.length,
Spannable.SPAN_EXCLUSIVE_EXCLUSIVE
Spannable.SPAN_EXCLUSIVE_EXCLUSIVE,
)

binding.btnNewsRankOpinion.text = spannableString
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ abstract class BindingProfileFragment : Fragment() {
container: ViewGroup?,
savedInstanceState: Bundle?,
): View? {
_binding = FragmentProfileBinding.inflate(layoutInflater)
_binding = FragmentProfileBinding.inflate(inflater, container, false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 λ¬Έμ œκ°€ μžˆμ—ˆκ΅°μš”..!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이마 탁..! :(

return binding.root
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class ProfileMemberFragment : BindingProfileFragment() {

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
userId = arguments?.getLong(Arg.PROFILE_USER_ID) ?: -1L
userId = arguments?.getLong(Arg.PROFILE_USER_ID) ?: return
}

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
Expand Down