Skip to content

Commit

Permalink
fix: 심사를 올리기 전까지는 홈 화면에 패키의 선물박스가 뜨지 않도록 변경 (#192)
Browse files Browse the repository at this point in the history
* fix: 심사를 올리기 전까지는 홈 화면에 패키의 선물박스가 뜨지 않도록 변경

* docs: 화면 이름에 맞도록 Swagger summary 수정
  • Loading branch information
leeeeeyeon authored Feb 23, 2024
1 parent 2b336ba commit 886e216
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public DataResponseDto<KakaoImgResponse> getKakaoMessageImgUrl(
return DataResponseDto.from(giftBoxService.getKakaoMessageImgUrl(giftBoxId));
}

@Operation(summary = "메인화면에 띄울 선물박스 조회")
@Operation(summary = "홈 화면에 띄울 선물박스 조회")
@GetMapping("/main")
public DataResponseDto<MainGiftBoxResponse> getMainGiftBox() {
return DataResponseDto.from(giftBoxService.getMainGiftBox());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,12 @@ public MainGiftBoxResponse getMainGiftBox() {
Optional<AdminGiftBox> adminGiftBox = adminGiftBoxReader.findByAdminType(
AdminType.ONBOARDING);

if (adminGiftBox.isPresent()) {
return MainGiftBoxResponse.from(adminGiftBox.get().getGiftBox());
} else {
return MainGiftBoxResponse.builder().build();
}
// if (adminGiftBox.isPresent()) {
// return MainGiftBoxResponse.from(adminGiftBox.get().getGiftBox());
// } else {
// return MainGiftBoxResponse.builder().build();
// }

return MainGiftBoxResponse.builder().build();

Check warning on line 347 in packy-api/src/main/java/com/dilly/gift/application/GiftBoxService.java

View check run for this annotation

Codecov / codecov/patch

packy-api/src/main/java/com/dilly/gift/application/GiftBoxService.java#L347

Added line #L347 was not covered by tests
}
}

0 comments on commit 886e216

Please sign in to comment.