Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 회원가입 및 로그인 API 응답값에 id값 추가 #204

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

leeeeeyeon
Copy link
Collaborator

@leeeeeyeon leeeeeyeon commented Mar 31, 2024

🛰️ Issue Number

#203

🪐 작업 내용

  • 회원가입 및 로그인 API 응답값에 id값을 추가하였습니다. d9edbac
  • java.lang.IllegalStateException: Cannot load driver class: com.mysql.cj.jdbc.Driver라는 에러가 발생하여 mysql-connector-j의 버전을 RDS에서 사용하는 MySQL 버전으로 명시하여 해결하였습니다. 26075c4

📚 Reference

✅ Check List

  • DB 스키마가 일치하는지 확인했나요?
  • SonarLint를 반영하여 코드를 수정했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@leeeeeyeon leeeeeyeon added the 🔨 fix Modifying previously implemented features label Mar 31, 2024
@leeeeeyeon leeeeeyeon self-assigned this Mar 31, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@678abf0). Click here to learn what that means.

Files Patch % Lines
...api/src/main/java/com/dilly/jwt/TokenProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #204   +/-   ##
==========================================
  Coverage           ?   26.70%           
  Complexity         ?      117           
==========================================
  Files              ?       95           
  Lines              ?     1071           
  Branches           ?       56           
==========================================
  Hits               ?      286           
  Misses             ?      772           
  Partials           ?       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leeeeeyeon leeeeeyeon merged commit 8bc2f02 into develop Mar 31, 2024
3 checks passed
@leeeeeyeon leeeeeyeon deleted the feature/add-memberId-to-response branch March 31, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 fix Modifying previously implemented features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant