Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flyway를 이용한 엔티티-테이블 매핑 검증 자동화 #273

Merged
merged 5 commits into from
Sep 1, 2024

Conversation

leeeeeyeon
Copy link
Collaborator

@leeeeeyeon leeeeeyeon commented Sep 1, 2024

🛰️ Issue Number

#269

🪐 작업 내용

  • flyway 모듈을 새로 만들어, flyway 관련 설정 및 파일을 flyway 모듈로 옮겼습니다.
  • Github Actions에서 엔티티-테이블 매핑 검증을 위해 매핑 테스트 후 종료되는 FlywayApplication을 추가하였습니다.
  • 매핑 검증 단계를 CI 스크립트에 추가하였습니다.

[ flyway 모듈을 새로 만든 이유 ]
처음에는 domain 모듈에 FlywayApplication을 만들고자 하였으나, api 모듈이 domain 모듈에 의존하기 때문에 SpringBootApplication이 2개가 발견되어 충돌이 발생했습니다.
api 모듈과 의존성이 없는 flyway 모듈을 만들어 충돌 문제를 해결하였습니다.

📚 Reference

✅ Check List

  • DB 스키마가 일치하는지 확인했나요?
  • SonarLint를 반영하여 코드를 수정했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@leeeeeyeon leeeeeyeon added the 🎁 feature New feature or request label Sep 1, 2024
@leeeeeyeon leeeeeyeon self-assigned this Sep 1, 2024
Copy link

sonarqubecloud bot commented Sep 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...ky-api/src/main/java/com/dilly/ApiApplication.java 50.00% <ø> (ø) 2.00 <0.00> (?)

@leeeeeyeon leeeeeyeon merged commit 443d03b into develop Sep 1, 2024
2 of 3 checks passed
@leeeeeyeon leeeeeyeon deleted the feature/flyway-automation-in-github-actions branch September 1, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant