Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 공지사항 단일 조회 API 구현 #279

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Conversation

leeeeeyeon
Copy link
Collaborator

@leeeeeyeon leeeeeyeon commented Sep 2, 2024

🛰️ Issue Number

#275

🪐 작업 내용

  • 공지사항 단일 조회 API를 구현하고, 테스트 코드를 작성하였습니다.
  • Exception 클래스 계층 구조를 변경하였습니다.
    • authorizationfailed처럼 디렉토리 내에 하나의 예외 클래스만 있을 경우 상위 디렉토리로 옮긴 후 디렉토리를 삭제하였습니다.
    • MemberNotFoundException이 여러 곳에서 사용될 것 같아 EntityNotFountException을 상속하여 따로 구현하였지만, 한 곳에서만 사용되어 삭제하였습니다.

📚 Reference

✅ Check List

  • DB 스키마가 일치하는지 확인했나요?
  • SonarLint를 반영하여 코드를 수정했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@leeeeeyeon leeeeeyeon added the 🎁 feature New feature or request label Sep 2, 2024
@leeeeeyeon leeeeeyeon self-assigned this Sep 2, 2024
Copy link

sonarqubecloud bot commented Sep 2, 2024

@leeeeeyeon
Copy link
Collaborator Author

Overall Project 41.16% -0.22%
Files changed 82.14% 🍏

File Coverage
NoticeImageReader.java 100% 🍏
AdminController.java 100% 🍏
NoticeImage.java 100% 🍏
SecurityUtil.java 81.48% 🍏
BoxReader.java 76.19% 🍏
EnvelopeReader.java 76.19% 🍏
AdminService.java 71.43% 🍏
NoticeReader.java 70.59% -29.41%
TokenProvider.java 49.17% 🍏
MemberReader.java 44.44% -27.78%
StickerReader.java 42.11% 🍏
JwtService.java 41.3% 🍏
GiftBoxReader.java 34.72% 🍏
PhotoReader.java 33.33% 🍏
MemberService.java 20.44% 🍏
LetterReader.java 20% 🍏

@leeeeeyeon leeeeeyeon merged commit 9c97c2a into develop Sep 2, 2024
2 checks passed
@leeeeeyeon leeeeeyeon deleted the feature/get-notice branch September 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant