Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PEP8 naming #199

Merged
merged 12 commits into from
Aug 26, 2024
Merged

Use PEP8 naming #199

merged 12 commits into from
Aug 26, 2024

Conversation

EarlMilktea
Copy link
Contributor

Description of the change:

Rename everything violating PEP8 naming convention.

@EarlMilktea EarlMilktea self-assigned this Aug 22, 2024
@EarlMilktea EarlMilktea marked this pull request as ready for review August 22, 2024 07:08
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 73.73913% with 151 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (e15dee2) to head (0bc7d28).
Report is 1 commits behind head on master.

Files Patch % Lines
graphix/visualization.py 3.37% 86 Missing ⚠️
graphix/gflow.py 69.72% 33 Missing ⚠️
graphix/pattern.py 88.39% 21 Missing ⚠️
graphix/transpiler.py 95.23% 6 Missing ⚠️
graphix/graphsim/basegraphstate.py 66.66% 2 Missing ⚠️
graphix/sim/tensornet.py 66.66% 2 Missing ⚠️
graphix/channels.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   76.19%   76.26%   +0.06%     
==========================================
  Files          37       37              
  Lines        5739     5739              
==========================================
+ Hits         4373     4377       +4     
+ Misses       1366     1362       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thierry-martinez thierry-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just made two minor remarks.

graphix/linalg.py Show resolved Hide resolved
graphix/visualization.py Outdated Show resolved Hide resolved
Copy link
Contributor

@masa10-f masa10-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@shinich1
Copy link
Contributor

@EarlMilktea thanks! please make sure docs build without error, and add a line or two to CHENGELOG.md.

@EarlMilktea
Copy link
Contributor Author

@shinich1 Done!

@shinich1
Copy link
Contributor

@EarlMilktea please add in [unreleased] part.

@EarlMilktea EarlMilktea merged commit 3c3531d into master Aug 26, 2024
19 checks passed
@EarlMilktea EarlMilktea deleted the naming branch August 26, 2024 14:59
mgarnier59 added a commit to mgarnier59/graphix-dev that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants