-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PEP8 naming #199
Use PEP8 naming #199
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 76.19% 76.26% +0.06%
==========================================
Files 37 37
Lines 5739 5739
==========================================
+ Hits 4373 4377 +4
+ Misses 1366 1362 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just made two minor remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@EarlMilktea thanks! please make sure docs build without error, and add a line or two to CHENGELOG.md. |
@shinich1 Done! |
@EarlMilktea please add in [unreleased] part. |
Description of the change:
Rename everything violating PEP8 naming convention.