Move all Pauli measurements to the front before Pauli presimulation #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a method "__extract_pauli_nodes" that applies exchange rules to move all Pauli measurements to the front of a pattern. This allows all the Pauli measurements to be presimulated, even if their initial domains depend on other measurements. On random circuits of 10 qubits (depth 10), number of remaining nodes after Pauli presimulation is reduced by a factor of 4 in average, and the time spent on state vector simulation is reduced by a factor 75 (including the time for Pauli presimulation).
EarlMilktea
requested changes
Sep 4, 2024
Suggested by EarlMilktea: TeamGraphix#209 (comment)
Suggested by EarlMilktea: TeamGraphix#209 (comment)
Suggested by EarlMilktea: TeamGraphix#209 (comment)
Suggested by EarlMilktea: TeamGraphix#209 (comment)
EarlMilktea
reviewed
Sep 7, 2024
Suggested by EarlMilktea: TeamGraphix#209 (comment)
Suggested by EarlMilktea: TeamGraphix#209 (comment)
EarlMilktea
approved these changes
Sep 7, 2024
shinich1
reviewed
Sep 12, 2024
graphix/pattern.py
Outdated
| else: | ||
| new_seq.append(cmd) | ||
| if not pauli_nodes_inserted: | ||
| new_seq.extend(pauli_nodes.values()) |
There was a problem hiding this comment.
How is this possible? I guess you need a standardization (I know we do it in measure_pauli but we should be explicit rather than implicit.
There was a problem hiding this comment.
Also, this might move the comand across possible dependency. please add a line of two of notes about consequences of this skipping or if this doesn't affect at all, then why so.
There was a problem hiding this comment.
I changed to a clearer structure in 7483827, providing proofs of the signal shifting: the function extract_pauli_nodes has been renamed to move_pauli_measurements_to_the_front and is now responsible for both shifting and moving the Pauli measurements in the sequence.
shinich1
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a method
__extract_pauli_nodesthat applies exchange rules to move all Pauli measurements to the front of a pattern. This allows all the Pauli measurements to be presimulated, even if their initial domains depend on other measurements.On random circuits of 10 qubits (depth 10), number of remaining nodes after Pauli presimulation is reduced by a factor of 4 on average, and the time spent on state vector simulation is reduced by a factor 75 (including the time for Pauli presimulation).