Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ViewPager2 dependency #11767

Open
wants to merge 1 commit into
base: refactor
Choose a base branch
from

Conversation

tsiflimagas
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

While #11282 removed the ViewPager2 dependency, #11684 intervened, hence this change was omitted. Just taking care of that.

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Dec 1, 2024
Copy link

sonarcloud bot commented Dec 1, 2024

@ShareASmile ShareASmile added dependency Issues and PRs related to dependencies rewrite Issues and PRs related to rewrite labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues and PRs related to dependencies rewrite Issues and PRs related to rewrite size/small PRs with less than 50 changed lines
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants