Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate #127

Merged
merged 81 commits into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
c67f180
Decaffeinate
Oxalin Dec 17, 2023
002218d
Fix babel/eslint scripts
Oxalin Dec 19, 2023
c89f792
Fix Linux import of untildify
Oxalin Dec 19, 2023
715d097
Improve our editor tools' configuration: editorconfig, babel and eslint
Oxalin Dec 28, 2023
193ed54
Update package.json
Oxalin Dec 28, 2023
20543e8
Package.json: set ES module
Oxalin Dec 28, 2023
c055751
Rewrite main module as ESM
Oxalin Dec 28, 2023
d8c208f
Add an API handler to instanciate the proper AutoLaunch subclass
Oxalin Dec 28, 2023
19569d3
AutoLaunch: fix mandatory name checkup
Oxalin Dec 29, 2023
802a5f5
Change code to ES6 module, create class and subclasses for AutoLaunch…
Oxalin Dec 29, 2023
2556a2f
Update some comments and log
Oxalin Dec 29, 2023
188e72f
Make sure to return appName in all cases
Oxalin Dec 29, 2023
c25a9d6
Remove decaffeinate comments
Oxalin Dec 29, 2023
d492a56
Fix ternary "options" verification
Oxalin Dec 29, 2023
e812375
Update tests for ESM and new code
Oxalin Dec 29, 2023
4f71c4f
Update eslint with a few more options
Oxalin Dec 29, 2023
554c51b
tests: fix useLaunchAgent under options.mac
Oxalin Dec 29, 2023
86d22d2
Bump node version dependency
Oxalin Dec 29, 2023
c21337a
Remove useless parameter in fixMacExecPath()
Oxalin Dec 29, 2023
9bc461b
Update .nvmrc to 14
Oxalin Dec 29, 2023
711dd69
Remove node 12 from CI
Oxalin Dec 29, 2023
83c8bd9
Linux/FreeBSD: move path correction directly in AutoLaunchAPI subclass
Oxalin Dec 29, 2023
eed11c0
Mac: move path correction directly in AutoLaunchAPI subclass
Oxalin Dec 29, 2023
b1f47e1
Mac: fix options reading for mac specific options
Oxalin Dec 29, 2023
51b7c08
Mac: fix array declaration
Oxalin Dec 29, 2023
15e83c2
Linux: remove parameters where not needed
Oxalin Dec 30, 2023
e37c562
fileBasedUtilities: remove mkdirp's callback and using a then()
Oxalin Dec 30, 2023
02b83bf
Tests: rework the test flow
Oxalin Dec 30, 2023
6374081
test: there is no ".opts" member anymore
Oxalin Dec 30, 2023
bbe3256
mac: remove useless parameter
Oxalin Dec 30, 2023
90660e8
Clean up autoLaunchHandler
Oxalin Dec 31, 2023
f60abb4
autoLaunch: really remove .opts member and fix tests
Oxalin Dec 31, 2023
1aca570
autoLaunch - mac: move fixOpts to AutoLaunchAPIMac.
Oxalin Dec 31, 2023
25d5cbe
tests: rename index.js to test.js
Oxalin Dec 31, 2023
1a1b4ec
tests: CI catches a non-Error, let's try to fix it
Oxalin Dec 31, 2023
4a70c3e
tests: test appName honoring for both *nix and Windows
Oxalin Dec 31, 2023
df12bb7
tests: explicitly log the appPath value to debug under macOS
Oxalin Dec 31, 2023
02fdfa0
tests: don't change escaped caracters in appPath on macOS
Oxalin Dec 31, 2023
f88f688
FileBasedUtilities: add a function to escape special characters in fi…
Oxalin Dec 31, 2023
396bd09
eslint: don't mess with linebreak style
Oxalin Dec 31, 2023
fe267a8
tests: will this fix the non-error reported under Linux in CI
Oxalin Dec 31, 2023
6986f35
tests: missing ";"
Oxalin Dec 31, 2023
ba384dd
tests: review our .then() and .catch()
Oxalin Dec 31, 2023
a69db65
test: another attemp to fix .enable() test under Linux
Oxalin Dec 31, 2023
a6f0952
tests: Linux is still getting a non-error in CI, but not local and no…
Oxalin Dec 31, 2023
90f7a9c
tests: POSIX, invert logic for escaping path with special characters
Oxalin Dec 31, 2023
2e8c5db
tests: fix expect()
Oxalin Dec 31, 2023
f16c59d
tests: this may fix the linux case
Oxalin Dec 31, 2023
73481b1
tests: Could this be a better solution for Linux testcase
Oxalin Dec 31, 2023
c1c6326
fileBasedUtilities: add missing return
Oxalin Dec 31, 2023
3ccfcad
tests: revert to using "function" for anonymous callback function in …
Oxalin Jan 1, 2024
349d048
tests: hopefully fix the .enable() test false error under Linux
Oxalin Jan 1, 2024
82fbeca
tests: add test coverage for AutoLauch constructor
Oxalin Jan 1, 2024
20cd60d
tests: add logs and a useless return that should never be called
Oxalin Jan 1, 2024
af0b43c
Workflow: update to Actions v3 since Node 12 (v2) is now deprecated.
Oxalin Jan 2, 2024
8891cd5
tests: another attemp at fixing .enable under CI - Linux
Oxalin Jan 2, 2024
a71ce01
tests: could this be only because of a timeout?
Oxalin Jan 2, 2024
d2e794d
tests: let's call done directly (which risk to cath non-error as before)
Oxalin Jan 2, 2024
651bab5
tests: oups, forgot to put back the good expectation while testing lo…
Oxalin Jan 2, 2024
2cc044d
tests: another alternative
Oxalin Jan 2, 2024
60fa131
tests: unify general and macOS ones
Oxalin Jan 2, 2024
aecd973
tests: .enable() CI on Linux, another variant
Oxalin Jan 2, 2024
e45716c
tests: CI Linux - with a catch(done)?
Oxalin Jan 2, 2024
2e2a6cc
tests: add a log to help us
Oxalin Jan 2, 2024
75411a7
tests: let's see if error is an instance of Error class
Oxalin Jan 2, 2024
4aadd9e
tests: fix for real CI on Linux by fix createFile() + fix catch(done)
Oxalin Jan 2, 2024
228708e
mockApi: remove unneeded return
Oxalin Jan 23, 2024
6174778
tests: rework some tests so we properly clean behind us and add POSIX…
Oxalin Jan 23, 2024
163593e
5.1.0
Oxalin Feb 26, 2024
4e64b1b
Remove mkdirp from dependencies
Oxalin Mar 7, 2024
9e18a8e
Merge branch 'decaffeinate' of github.com:Oxalin/node-auto-launch int…
Oxalin Mar 22, 2024
264b7b2
Windows: improve tracking path used to launch app and error messages
Oxalin Mar 22, 2024
fe027c3
Update comments for better understanding of the code
Oxalin Mar 22, 2024
7d426cf
5.1.1-rc.0
Oxalin Mar 22, 2024
fed35dc
6.0.0
Oxalin Mar 22, 2024
ca7b02e
6.0.1-rc.0
Oxalin Mar 22, 2024
547c9da
Bump version to 6.0.0 and actually prepare release candidate
Oxalin Mar 22, 2024
aa1b0f3
Merge branch 'decaffeinate' of github.com:Oxalin/node-auto-launch int…
Oxalin Mar 22, 2024
64f54c5
Merge branch 'Oxalin-decaffeinate'
Oxalin Mar 22, 2024
48511cc
Merge pull request #126 from Oxalin/master
4ver Apr 8, 2024
5b21022
Reformat and lint fix
4ver Apr 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"presets": [ "@babel/preset-env" ]
}
17 changes: 4 additions & 13 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,9 @@
root = true

[*]
charset = "utf8"
charset = "utf-8"
indent_style = space
indent_size = 2
end_of_line = lf
trim_trailing_whitespace = true
insert_final_newline = true

[*.coffee]
indent_style = space
indent_size = 4

[*.js]
indent_style = space
indent_size = 4

[*.json]
indent_style = space
indent_size = 4
48 changes: 48 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
{
"extends": "airbnb-base",
"env": {
"browser": true,
"mocha": true
},
"parser": "@babel/eslint-parser",
"parserOptions": {
"requireConfigFile": false,
"sourceType": "module"
},
"rules": {
"brace-style": "warn",
"class-methods-use-this": 0,
"comma-dangle": [
"warn",
"only-multiline"
],
"indent": [
"warn",
2,
{
"SwitchCase": 1
}
],
"lines-between-class-members": "off",
"linebreak-style": "off",
"max-len": [
"warn",
128
],
"no-promise-executor-return": "warn",
"no-var": "error",
"no-useless-constructor": "off",
"object-curly-newline": "warn",
"object-curly-spacing": "warn",
"prefer-arrow-callback": "off",
"prefer-const": "warn",
"prefer-destructuring": "off",
"import/extensions": [
"error",
"ignorePackages",
{
"js": "always"
}
]
}
}
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ jobs:
strategy:
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
node-version: ["12", "14", "16", "18", "20"]
node-version: ["14", "16", "18", "20"]

runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Set up Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
2 changes: 1 addition & 1 deletion .npmignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
*
!dist/*
!src/*
!README.md
!LICENSE.md
!package.json
Loading
Loading