Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add railcraft compat for the two tracks #179

Draft
wants to merge 1 commit into
base: 1.12
Choose a base branch
from

Conversation

liach
Copy link

@liach liach commented Feb 19, 2019

Runs properly but advanced detector track kit item has texture issues

As a result, this is a draft. @modmuss50 hope you can review and spot issues early.

This does not require steves carts to ship railcraft api to run.

Runs properly but advanced detector track kit item has texture issues

Signed-off-by: liach <[email protected]>
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, I will need to find the time to test it.

@@ -50,6 +50,9 @@ repositories {
name = "Modmuss50"
url = "http://maven.modmuss50.me/"
}
flatDir {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this? I do not see the railcraft jar, and I would be a lot happier using maven, even if it was from curse's maven endpoint.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

railcraft does not have a proper maven set up now unfortunately. i might see if railcraft can use bintray or something similar.

@modmuss50
Copy link
Member

@GoryMoon might also want to take a look at this.

@liach
Copy link
Author

liach commented Feb 20, 2019

it runs now but has some texture issues with the item. i am identifying the cause of the texture issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants