-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] 16,17,18: use gevent 22.10.2 #636
[IMP] 16,17,18: use gevent 22.10.2 #636
Conversation
Oh, I have found the same in OpenUpgrade - https://github.com/OCA/OpenUpgrade/actions/runs/11773816204/job/32791447402 - and thought it was a temporary glitch. Thanks for the quick reaction. |
As this issue is blocking, we’ll proceed with merging it now. If any adjustments for ARM support are needed later, we can address them in subsequent PRs. |
@ap-wtioit the pipeline will attempt to build the arm64 version as well so let's wait and see what happens |
16.0 needs another fix (currently testing locally and on our CI) |
pip install gevent==21.8.0 fails with exception when installing with pip in ubuntu/debian. gevent 22.10.2 then also requires greenlet 2.0.2
Also the tests are not testing the images from the MR but the ones from the last build: https://productionresultssa15.blob.core.windows.net/actions-results/5ee68d24-d2da-4615-89a8-71c8d356766b/workflow-job-run-0a389663-ebb5-589c-cbc5-39a4d780c272/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-11-11T09%3A10%3A47Z&sig=kLxCkEMmy0ofrGGPs1zgSHFnBcvTr27%2BRvy1vrUgE44%3D&ske=2024-11-11T18%3A32%3A08Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-11-11T06%3A32%3A08Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-08-04&sp=r&spr=https&sr=b&st=2024-11-11T09%3A00%3A42Z&sv=2024-08-04
that's why 16.0 still succeeded with this patch |
1208bd9
to
355d63f
Compare
The patch should work for 16.0 as well now. Root cause seems to be this one: gevent/gevent#2076, gevent 21.8.0 has a dependency to |
pip install gevent==21.8.0 fails with exception when installing with pip in ubuntu/debian. gevent 22.10.2 then also requires greenlet 2.0.2
docker run --rm -it python:3.10-bookworm bash -c 'pip install gevent==21.8.0'
fails withdocker run --rm -it python:3.10-bookworm bash -c 'pip install gevent==22.10.2'
succeeds and is the same version suggested by odoo for python3.11 so it should most likely also work@PCatinean could you also have a look if this looks ok for arm64?
info @wt-io-it