Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error with NDK r27 #5615

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix build error with NDK r27 #5615

merged 1 commit into from
Aug 8, 2024

Conversation

Galasnow
Copy link
Contributor

@Galasnow Galasnow commented Aug 6, 2024

Enable policy CMP0057 for cmake version >= 3.3. Fix Issue #5592

Enable policy CMP0057 for cmake version >= 3.3
@tencent-adm
Copy link
Member

tencent-adm commented Aug 6, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (391152f) to head (a8a4538).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5615       +/-   ##
===========================================
- Coverage   94.73%   89.93%    -4.80%     
===========================================
  Files         786      263      -523     
  Lines      248546    77166   -171380     
===========================================
- Hits       235462    69403   -166059     
+ Misses      13084     7763     -5321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Galasnow
Copy link
Contributor Author

Galasnow commented Aug 7, 2024

For Android X86 ABI, manually turning off avx512 by -DNCNN_AVX512=OFF can pass the compilation. It's a problem beyond my capability QAQ, I will report an issue in NDK repository.

@nihui nihui merged commit 5b5c1fd into Tencent:master Aug 8, 2024
68 of 71 checks passed
@nihui
Copy link
Member

nihui commented Aug 8, 2024

Thanks for your contribution !

@nihui
Copy link
Member

nihui commented Aug 8, 2024

For Android X86 ABI, manually turning off avx512 by -DNCNN_AVX512=OFF can pass the compilation. It's a problem beyond my capability QAQ, I will report an issue in NDK repository.

maybe -DNCNN_AVX512BF16=OFF is enough, so we still gain most avx512 optimizations in ncnn

@Galasnow
Copy link
Contributor Author

Galasnow commented Aug 8, 2024

maybe -DNCNN_AVX512BF16=OFF is enough, so we still gain most avx512 optimizations in ncnn

Build pass on Windows. Thanks! I learned a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants