Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action-sheet): optimize ActionSheet component #1541

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

yanhao98
Copy link

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

image image

📝 更新日志

  • fix(ActionSheet): optimize ActionSheet component

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Aug 23, 2024

完成

@yanhao98
Copy link
Author

不过貌似是组件本身就有的问题引起的。

  <t-action-sheet :items="['1', '2']" />

就会

image

PR 作的修改我通过在自己项目 pnpm patch 后API方式打开sheet没有报错(因为我环境可能有问题tdesign-mobile-vue跑不起来)。

@anlyyao
Copy link
Collaborator

anlyyao commented Sep 11, 2024

@yanhao98 我来看看~, 期望时修改函数式调用时控制台告警对吧

@yanhao98
Copy link
Author

@yanhao98 我来看看~, 期望时修改函数式调用时控制台告警对吧
对。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants