Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade vite to v5, vitest to v2, typescript to v5 #3115

Merged
merged 3 commits into from
Oct 10, 2024
Merged

build: upgrade vite to v5, vitest to v2, typescript to v5 #3115

merged 3 commits into from
Oct 10, 2024

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Sep 25, 2024 •
edited by uyarn
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@honkinglin
Copy link
Collaborator Author

先拉到本地测试下，没问题再合并

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

完成

@honkinglin
Copy link
Collaborator Author

预览页面样式丢失了，得排查下

@honkinglin honkinglin changed the title build(upgrade vite vitest version): upgrade vite to v5, vitest to v2 【暂不合并】build(upgrade vite vitest version): upgrade vite to v5, vitest to v2 Sep 25, 2024
@honkinglin honkinglin closed this Oct 1, 2024
@honkinglin honkinglin reopened this Oct 1, 2024
@honkinglin
Copy link
Collaborator Author

预览页面样式丢失了，得排查下

Vite5 中的 Rollup 版本升级到4导致 tree-shaking 策略调整，添加 sideEffects 解决了

"sideEffects": [
    "src/**/style/**"
    ...
  ],

@honkinglin honkinglin changed the title 【暂不合并】build(upgrade vite vitest version): upgrade vite to v5, vitest to v2 build(upgrade vite vitest version): upgrade vite to v5, vitest to v2, typescript to v5 Oct 1, 2024
@honkinglin honkinglin changed the title build(upgrade vite vitest version): upgrade vite to v5, vitest to v2, typescript to v5 build(upgrade vite vitest typescript version): upgrade vite to v5, vitest to v2, typescript to v5 Oct 1, 2024
@uyarn
Copy link
Collaborator

uyarn commented Oct 10, 2024

/update-common

@uyarn uyarn changed the title build(upgrade vite vitest typescript version): upgrade vite to v5, vitest to v2, typescript to v5 build: upgrade vite to v5, vitest to v2, typescript to v5 Oct 10, 2024
@uyarn uyarn closed this Oct 10, 2024
@uyarn uyarn reopened this Oct 10, 2024
@uyarn
Copy link
Collaborator

uyarn commented Oct 10, 2024

LGTM

@uyarn uyarn merged commit 6a6eacd into develop Oct 10, 2024
21 checks passed
@uyarn uyarn deleted the feat/vite-update branch October 10, 2024 10:22
@uyarn uyarn mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn approved these changes

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

@HaixingOoO HaixingOoO Awaiting requested review from HaixingOoO HaixingOoO is a code owner

@NWYLZW NWYLZW Awaiting requested review from NWYLZW NWYLZW is a code owner

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honkinglin @uyarn