Support InnerShadowFilter. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hparty
requested review from
kevingpqi123,
domchen,
lvpengwei and
shlzxjp
as code owners
|
|
domchen
reviewed
Nov 8, 2024
| std::shared_ptr<ImageFilter> ImageFilter::InnerShadow(float dx, float dy, float blurrinessX, | ||
| float blurrinessY, const Color& color) { | ||
|
|
||
| auto dropShadowFilter = DropShadowOnly(dx, dy, blurrinessX, blurrinessY, Color::Black()); |
There was a problem hiding this comment.
这里应该是用BlurImageFilter去实现，DropShadow也是调用了BlurImageFilter。
domchen
reviewed
Nov 8, 2024
include/tgfx/core/ImageFilter.h
Outdated
Comment on lines
98
to
105
| * Create a filter that renders an inner shadow, in exactly the same manner as the InnerShadow(), | ||
| * except that the resulting image does not include the input content. | ||
| * @param dx The X offset of the shadow. | ||
| * @param dy The Y offset of the shadow. | ||
| * @param blurrinessX The blur radius for the shadow, along the X axis. | ||
| * @param blurrinessY The blur radius for the shadow, along the Y axis. | ||
| * @param color The color of the inner shadow. | ||
| */ |
domchen
reviewed
Nov 8, 2024
|
|
||
| auto colorProcessor = ConstColorProcessor::Make(color, InputMode::Ignore); | ||
|
|
||
| // get inverted drop shadow mask and fill it with color |
domchen
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持内阴影滤镜
