Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

personalized daily quote section by adding different categories #194

Closed
wants to merge 5 commits into from

Conversation

sezallagwal
Copy link
Contributor

@sezallagwal sezallagwal commented Oct 29, 2024

Description

Please include a summary of the changes and the related issue. Also, explain the motivation behind this PR.

Related Issue

Fixes #162
fixes #49

Recording.2024-10-29.171735.mp4

@TenzDelek please review this pr thanks!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 29, 2024

@sezallagwal is attempting to deploy a commit to the deleksharpgmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@sezallagwal sezallagwal changed the title personalized daily iuote section by adding different categories personalized daily quote section by adding different categories Oct 29, 2024
@TenzDelek
Copy link
Owner

fix the conflict and it is ready to merge

@sezallagwal
Copy link
Contributor Author

@TenzDelek please merge this pr and assign @amitb0ra with appropriate level

@sezallagwal
Copy link
Contributor Author

@sanjay-kv @TenzDelek any updates?

@TenzDelek TenzDelek self-requested a review November 25, 2024 10:45
@sezallagwal sezallagwal closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspirational Quotes Feature Feature Request: Quote of the Day Customization
2 participants