Bug fixes for the Mythic+ End of Run panel

- General fixes applied to the Mythic+ Panel.
- The Mythic+ section in the options panel can now be translated.
- More fixes for text color.

boot.lua

@@ -18,8 +18,8 @@
 		local addonName, Details222 = ...
 		local version, build, date, tocversion = GetBuildInfo()
 
-		Details.build_counter = 12281
-		Details.alpha_build_counter = 12281 --if this is higher than the regular counter, use it instead
+		Details.build_counter = 12294
+		Details.alpha_build_counter = 12294 --if this is higher than the regular counter, use it instead
 		Details.dont_open_news = true
 		Details.game_version = version
 		Details.userversion = version .. " " .. Details.build_counter
@@ -161,6 +161,11 @@ do
 	--]=]
 
 	local news = {
+		{"v10.2.5.12294.155", "February 08th, 2024"},
+		"General fixes applied to the Mythic+ Panel.",
+		"The Mythic+ section in the options panel can now be translated.",
+		"More fixes for text color.",
+
 		{"v10.2.5.12281.155", "February 07th, 2024"},
 		"Released the new panel for the Mythic+ Run Completion.",
 		"The list of Crowd Control spells is now sourced from the Lib Open Raid.",

core/parser.lua

@@ -5871,13 +5871,13 @@ local SPELL_POWER_PAIN = SPELL_POWER_PAIN or (PowerEnum and PowerEnum.Pain) or 1
 			Details222.MythicPlus.time = 0.1
 		end
 
-		if (level >= 28 or Details.user_is_patreon_supporter) then --debug
+		--if (level >= 28 or Details.user_is_patreon_supporter) then --debug
 			C_Timer.After(0, function()
 				if (ChallengeModeCompleteBanner) then
 					ChallengeModeCompleteBanner.timeToHold = 0.1
 				end
 			end)
-		end
+		--end
 
 		--send mythic dungeon end event
 		local zoneName, instanceType, difficultyID, difficultyName, maxPlayers, dynamicDifficulty, isDynamic, instanceMapID, instanceGroupSize = GetInstanceInfo()

frames/window_cdtracker.lua

@@ -792,7 +792,7 @@ end
             --warning2:SetText("This is a concept of a cooldown tracker using the new library 'Open Raid' which uses comms to update cooldown timers.\nThe code to implement is so small that can fit inside a weakaura\nIf you're a coder, the implementation is on Details/frames/window_cdtracker.lua")
 
             cooldownSelectionFrame:RegisterEvent("GROUP_ROSTER_UPDATE")
-            cooldownSelectionFrame:RegisterEvent("PLAYER_STARTED_MOVING")
+            --cooldownSelectionFrame:RegisterEvent("PLAYER_STARTED_MOVING") --debug
 
             local maxClasses = 13
 
@@ -821,6 +821,10 @@ end
                 --below the player name, show a list in vertical with checkboxes to enable/disable cooldowns for that class
                 --use DetailsFramework:BuildMenuVolatile() to build the each list
 
+                if (not cooldownSelectionFrame:IsShown()) then
+                    return
+                end
+
                 local amountOfUnits = GetNumGroupMembers()
 
                 if (amountOfUnits == 0) then
@@ -892,6 +896,12 @@ end
                     index = index + 1
                 end
             end)
+
+            cooldownSelectionFrame:GetScript("OnEvent")(cooldownSelectionFrame, "GROUP_ROSTER_UPDATE")
+
+            cooldownSelectionFrame:SetScript("OnShow", function()
+                cooldownSelectionFrame:GetScript("OnEvent")(cooldownSelectionFrame, "GROUP_ROSTER_UPDATE")
+            end)
         end
 
         _G.DetailsPluginContainerWindow.OpenPlugin(_G.DetailsCDTrackerWindow)

frames/window_options2_sections.lua

@@ -6889,7 +6889,7 @@ do
     local buildSection = function(sectionFrame)
 
         local sectionOptions = {
-            {type = "label", get = function() return Loc["STRING_OPTIONS_GENERAL_ANCHOR"] end, text_template = subSectionTitleTextTemplate},
+            {type = "label", get = function() return Loc["STRING_OPTIONS_MPLUS_DPS_ANCHOR"] end, text_template = subSectionTitleTextTemplate},
 
             {
                 type = "toggle",
@@ -6898,8 +6898,8 @@ do
                     Details.mythic_plus.mythicrun_time_type = value and 1
                     sectionFrame:GetWidgetById("mythic_time_2"):SetValue(not value)
                 end,
-                name = "Use Total Combat Time",
-                desc = "The overall segment for the Mythic+ run will use 'totalDamage / totalCombatTime' to calculate DPS.",
+                name = Loc["STRING_OPTIONS_MPLUS_TIME_INCOMBAT"],
+                desc = Loc["STRING_OPTIONS_MPLUS_TIME_INCOMBAT_DESC"],
                 id = "mythic_time_1",
             },
 
@@ -6910,21 +6910,22 @@ do
                     Details.mythic_plus.mythicrun_time_type = value and 2
                     sectionFrame:GetWidgetById("mythic_time_1"):SetValue(not value)
                 end,
-                name = "Use Run Time",
-                desc = "The overall segment for the Mythic+ run will use 'totalDamage / runTime' to calculate DPS.",
+                name = Loc["STRING_OPTIONS_MPLUS_TIME_RUNTIME"],
+                desc = Loc["STRING_OPTIONS_MPLUS_TIME_RUNTIME_DESC"],
                 id = "mythic_time_2",
             },
 
             {type = "blank"},
+            {type = "label", get = function() return Loc["STRING_SEGMENTS"] end, text_template = subSectionTitleTextTemplate},
 
             {--dedicated segment for bosses
                 type = "toggle",
                 get = function() return Details.mythic_plus.boss_dedicated_segment end,
                 set = function(self, fixedparam, value)
                     Details.mythic_plus.boss_dedicated_segment = value
                 end,
-                name = "New Combat on Boss Pull",
-                desc = "If a boss is pulled while in combat, Details! close the combat and start a new one for the boss.",
+                name = Loc["STRING_OPTIONS_MPLUS_BOSSNEWCOMBAT"],
+                desc = Loc["STRING_OPTIONS_MPLUS_BOSSNEWCOMBAT_DESC"],
             },
 
             {--make overall when done
@@ -6933,8 +6934,8 @@ do
                 set = function(self, fixedparam, value)
                     Details.mythic_plus.make_overall_when_done = value
                 end,
-                name = "Make Overall Segment",
-                desc = "When the run is done, make an overall segment.",
+                name = Loc["STRING_OPTIONS_MPLUS_MAKEOVERALL"],
+                desc = Loc["STRING_OPTIONS_MPLUS_MAKEOVERALL_DESC"],
             },
 
             {--merge trash
@@ -6943,23 +6944,22 @@ do
                 set = function(self, fixedparam, value)
                     Details.mythic_plus.merge_boss_trash = value
                 end,
-                name = "Merge Trash",
-                desc = "Merge Trash",
+                name = Loc["STRING_OPTIONS_MPLUS_MERGETRASH"],
+                desc = Loc["STRING_OPTIONS_MPLUS_MERGETRASH"],
             },
 
             {type = "blank"},
+            {type = "label", get = function() return Loc["STRING_OPTIONS_MPLUS_PANELS_ANCHOR"] end, text_template = subSectionTitleTextTemplate},
 
             {--show chart popup
                 type = "toggle",
                 get = function() return Details.mythic_plus.show_damage_graphic end,
                 set = function(self, fixedparam, value)
                     Details.mythic_plus.show_damage_graphic = value
                 end,
-                name = "Show End of M+ Panel",
-                desc = "Show End of M+ Panel",
+                name = Loc["STRING_OPTIONS_MPLUS_SHOWENDPANEL"],
+                desc = Loc["STRING_OPTIONS_MPLUS_SHOWENDPANEL"],
             },
-
-
         }
 
         sectionFrame.sectionOptions = sectionOptions